starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13995] [MERGED] Stop DoSing users with renderer errors #29875

New Issue
Open
opened 2026-01-31 09:37:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:37:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13995
Author: @lhecker
Created: 9/14/2022
Status: ✅ Merged
Merged: 9/16/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/renderer-fixup

📝 Commits (5)

📊 Changes

1 file changed (+20 additions, -19 deletions)

View changed files

📝 src/renderer/base/renderer.cpp (+20 -19)

📄 Description

If a rendering engine constantly throws error we'll effectively
denial-of-service our users by drowning them in warning popups.
This commit fixes the issue by limiting the retries in all cases.

Issue found in: #13985

Validation Steps Performed

  • Add a THROW_HR(E_INVALIDARG); in AtlasEngine::StartPaint()
  • Launch Windows Terminal
  • Only one warning popup shows up ✅
  • Rendering is disabled until one clicks "resume" ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13995 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 9/14/2022 **Status:** ✅ Merged **Merged:** 9/16/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/renderer-fixup` --- ### 📝 Commits (5) - [`a8c9776`](https://github.com/microsoft/terminal/commit/a8c9776bacbf492065a6f2973920ad20c7818e32) Stop DoSing users with renderer errors - [`a6cf48c`](https://github.com/microsoft/terminal/commit/a6cf48c050827af1040481ed65bdca092ed0b2f6) Fix test failures - [`f14ae33`](https://github.com/microsoft/terminal/commit/f14ae3313e3e5661af8c72560b60e9c3cbafb34f) Fix test failures - [`7b7cf1a`](https://github.com/microsoft/terminal/commit/7b7cf1aa77de014a10382eed4cadbd7df359ee7a) Fix namespace issue - [`899c23a`](https://github.com/microsoft/terminal/commit/899c23a3c73e9435f2ef83a505824ae06abddc31) Whoops ### 📊 Changes **1 file changed** (+20 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/base/renderer.cpp` (+20 -19) </details> ### 📄 Description If a rendering engine constantly throws error we'll effectively denial-of-service our users by drowning them in warning popups. This commit fixes the issue by limiting the retries in all cases. Issue found in: #13985 ## Validation Steps Performed * Add a `THROW_HR(E_INVALIDARG);` in `AtlasEngine::StartPaint()` * Launch Windows Terminal * Only one warning popup shows up ✅ * Rendering is disabled until one clicks "resume" ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29875
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?