[PR #13994] [MERGED] AtlasEngine: Properly detect shader model 4 support #29877

Open
opened 2026-01-31 09:37:23 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13994
Author: @lhecker
Created: 9/14/2022
Status: ✅ Merged
Merged: 9/15/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/atlas-engine-fixup2


📝 Commits (1)

  • c20ecfb AtlasEngine: Properly detect shader model 4 support

📊 Changes

1 file changed (+17 additions, -3 deletions)

View changed files

📝 src/renderer/atlas/AtlasEngine.cpp (+17 -3)

📄 Description

Direct3D 10.0 and 10.1 only have optional support for shader model 4.
This commit fixes our assumption that it's always present by checking
ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x first.

Closes #13985

Validation Steps Performed

  • Set feature level to 10.1 via dxcpl
  • CheckFeatureSupport is called and doesn't throw ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13994 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 9/14/2022 **Status:** ✅ Merged **Merged:** 9/15/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/atlas-engine-fixup2` --- ### 📝 Commits (1) - [`c20ecfb`](https://github.com/microsoft/terminal/commit/c20ecfb5c165e1d4e72239e358f072b6125f06b7) AtlasEngine: Properly detect shader model 4 support ### 📊 Changes **1 file changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/atlas/AtlasEngine.cpp` (+17 -3) </details> ### 📄 Description Direct3D 10.0 and 10.1 only have optional support for shader model 4. This commit fixes our assumption that it's always present by checking `ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x` first. Closes #13985 ## Validation Steps Performed * Set feature level to 10.1 via `dxcpl` * `CheckFeatureSupport` is called and doesn't throw ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:23 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29877