[PR #13995] Stop DoSing users with renderer errors #29880

Open
opened 2026-01-31 09:37:24 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/13995

State: closed
Merged: Yes


If a rendering engine constantly throws error we'll effectively
denial-of-service our users by drowning them in warning popups.
This commit fixes the issue by limiting the retries in all cases.

Issue found in: #13985

Validation Steps Performed

  • Add a THROW_HR(E_INVALIDARG); in AtlasEngine::StartPaint()
  • Launch Windows Terminal
  • Only one warning popup shows up ✅
  • Rendering is disabled until one clicks "resume" ✅
**Original Pull Request:** https://github.com/microsoft/terminal/pull/13995 **State:** closed **Merged:** Yes --- If a rendering engine constantly throws error we'll effectively denial-of-service our users by drowning them in warning popups. This commit fixes the issue by limiting the retries in all cases. Issue found in: #13985 ## Validation Steps Performed * Add a `THROW_HR(E_INVALIDARG);` in `AtlasEngine::StartPaint()` * Launch Windows Terminal * Only one warning popup shows up ✅ * Rendering is disabled until one clicks "resume" ✅
claunia added the pull-request label 2026-01-31 09:37:24 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29880