[PR #14013] [MERGED] Add support for fractional font sizes #29885

Open
opened 2026-01-31 09:37:26 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14013
Author: @lhecker
Created: 9/15/2022
Status: ✅ Merged
Merged: 9/16/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/6678-fractional-font-sizes


📝 Commits (3)

  • 87bb319 Add support for fractional font sizes
  • bfd208e Round floats on write
  • 8fb1d5c Fix requestedSize.X rounding

📊 Changes

22 files changed (+65 additions, -56 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -2)
📝 src/cascadia/PublicTerminalCore/HwndTerminal.cpp (+2 -2)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+14 -10)
📝 src/cascadia/TerminalControl/ControlCore.h (+3 -3)
📝 src/cascadia/TerminalControl/ControlCore.idl (+1 -1)
📝 src/cascadia/TerminalControl/ControlInteractivity.cpp (+8 -8)
📝 src/cascadia/TerminalControl/ControlInteractivity.h (+3 -3)
📝 src/cascadia/TerminalControl/IControlSettings.idl (+1 -1)
📝 src/cascadia/TerminalControl/TermControl.cpp (+3 -3)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -1)
📝 src/cascadia/TerminalControl/TermControl.idl (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+1 -1)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+1 -1)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+2 -1)
📝 src/cascadia/TerminalSettingsModel/FontConfig.idl (+1 -1)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+1 -1)
📝 src/cascadia/inc/ControlProperties.h (+1 -1)
📝 src/renderer/atlas/AtlasEngine.api.cpp (+6 -5)

...and 2 more files

📄 Description

After this commit a user may specify fractional font sizes.
Support was only implemented for AtlasEngine however.
DxEngine continues to use rounded (integer) font sizes.

Closes #6678

Validation Steps Performed

  • Install a bitmap font that requires fractional font sizes
    (e.g. Terminus TTF, https://files.ax86.net/terminus-ttf/)
  • Set font size to something integer (e.g. 14pt)
    Glyphs are blurry ✅
  • Set font size to something fractional (e.g. 13.5pt)
    Glyphs are crisp ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14013 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 9/15/2022 **Status:** ✅ Merged **Merged:** 9/16/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/6678-fractional-font-sizes` --- ### 📝 Commits (3) - [`87bb319`](https://github.com/microsoft/terminal/commit/87bb3194e945acdc00892300bb303a389d3ce28f) Add support for fractional font sizes - [`bfd208e`](https://github.com/microsoft/terminal/commit/bfd208e5332806238cc160437e2e19c3eba3ae62) Round floats on write - [`8fb1d5c`](https://github.com/microsoft/terminal/commit/8fb1d5ce5c0b5d9dcc9404eee9dfe998c1209b12) Fix requestedSize.X rounding ### 📊 Changes **22 files changed** (+65 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -2) 📝 `src/cascadia/PublicTerminalCore/HwndTerminal.cpp` (+2 -2) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+14 -10) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+3 -3) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+1 -1) 📝 `src/cascadia/TerminalControl/ControlInteractivity.cpp` (+8 -8) 📝 `src/cascadia/TerminalControl/ControlInteractivity.h` (+3 -3) 📝 `src/cascadia/TerminalControl/IControlSettings.idl` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+3 -3) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/FontConfig.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+1 -1) 📝 `src/cascadia/inc/ControlProperties.h` (+1 -1) 📝 `src/renderer/atlas/AtlasEngine.api.cpp` (+6 -5) _...and 2 more files_ </details> ### 📄 Description After this commit a user may specify fractional font sizes. Support was only implemented for AtlasEngine however. DxEngine continues to use rounded (integer) font sizes. Closes #6678 ## Validation Steps Performed * Install a bitmap font that requires fractional font sizes (e.g. Terminus TTF, https://files.ax86.net/terminus-ttf/) * Set font size to something integer (e.g. 14pt) Glyphs are blurry ✅ * Set font size to something fractional (e.g. 13.5pt) Glyphs are crisp ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:26 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29885