[PR #14040] [MERGED] Fix font size rounding in the settings UI #29899

Open
opened 2026-01-31 09:37:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14040
Author: @lhecker
Created: 9/19/2022
Status: ✅ Merged
Merged: 9/20/2022
Merged by: @DHowett

Base: main ← Head: dev/lhecker/14024-winui


📝 Commits (3)

📊 Changes

3 files changed (+14 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+11 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/pch.h (+1 -0)

📄 Description

This fixes an issue with c51bb3a, where some fractional font
sizes are displayed as something like 13.600000000001.

Closes #14024

Validation Steps Performed

  • Enter a font size of 13.6 and save
  • NumberBox displays "13.6" ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14040 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 9/19/2022 **Status:** ✅ Merged **Merged:** 9/20/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/lhecker/14024-winui` --- ### 📝 Commits (3) - [`254aaf9`](https://github.com/microsoft/terminal/commit/254aaf9645c364dc4b392e9ecab772dd12a8a7b2) Fix font size rounding in the settings UI - [`8e1cae9`](https://github.com/microsoft/terminal/commit/8e1cae949e02d79289e23cb898da52ec81aba5ed) Address feedback - [`4366d0e`](https://github.com/microsoft/terminal/commit/4366d0ecd6f52cd64d3668c351366c55b7684745) Reformat XAML ### 📊 Changes **3 files changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+11 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/pch.h` (+1 -0) </details> ### 📄 Description This fixes an issue with c51bb3a, where some fractional font sizes are displayed as something like 13.600000000001. Closes #14024 ## Validation Steps Performed * Enter a font size of 13.6 and save * NumberBox displays "13.6" ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29899