[PR #14047] [MERGED] Add support for scroll bar 'always' setting #29905

Open
opened 2026-01-31 09:37:32 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14047
Author: @sotteson1
Created: 9/20/2022
Status: Merged
Merged: 9/21/2022
Merged by: @undefined

Base: mainHead: add-scrollbar-always


📝 Commits (5)

  • b342f50 Add support for scroll bar 'always' setting
  • 834f5a2 Add schema change
  • 46f4353 Fixing formatting issues
  • 51ecca3 Fixing formatting issues 2
  • 7e04f48 Address PR suggestions

📊 Changes

10 files changed (+131 additions, -10 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -1)
📝 src/cascadia/TerminalControl/IControlSettings.idl (+2 -1)
src/cascadia/TerminalControl/ScrollBarVisualStateManager.cpp (+57 -0)
src/cascadia/TerminalControl/ScrollBarVisualStateManager.h (+37 -0)
src/cascadia/TerminalControl/ScrollBarVisualStateManager.idl (+8 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+3 -3)
📝 src/cascadia/TerminalControl/TermControl.xaml (+5 -0)
📝 src/cascadia/TerminalControl/TerminalControlLib.vcxproj (+8 -1)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+6 -2)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+3 -2)

📄 Description

This fixes #3454 by adding support for an "always" mode for the scroll bar.

This change uses a custom VisualStateManager to keep the scroll bar from collapsing if the profile is using the 'always' setting.

Validation Steps Performed

Tried updating settings.json directly and using the UI and making sure the scroll bar behaves as expected.

Closes #3454


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14047 **Author:** [@sotteson1](https://github.com/sotteson1) **Created:** 9/20/2022 **Status:** ✅ Merged **Merged:** 9/21/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `add-scrollbar-always` --- ### 📝 Commits (5) - [`b342f50`](https://github.com/microsoft/terminal/commit/b342f506588319f67f89fbc587908caa2bb964b6) Add support for scroll bar 'always' setting - [`834f5a2`](https://github.com/microsoft/terminal/commit/834f5a223856e69862a239c24204d37713278dc6) Add schema change - [`46f4353`](https://github.com/microsoft/terminal/commit/46f4353a9c80f7e4bb676223ade83559b2cbf9f5) Fixing formatting issues - [`51ecca3`](https://github.com/microsoft/terminal/commit/51ecca310435be860a37b0445261123d3838ac17) Fixing formatting issues 2 - [`7e04f48`](https://github.com/microsoft/terminal/commit/7e04f487ce16b7c20cd51edf4be1c8bc9b6313fa) Address PR suggestions ### 📊 Changes **10 files changed** (+131 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -1) 📝 `src/cascadia/TerminalControl/IControlSettings.idl` (+2 -1) ➕ `src/cascadia/TerminalControl/ScrollBarVisualStateManager.cpp` (+57 -0) ➕ `src/cascadia/TerminalControl/ScrollBarVisualStateManager.h` (+37 -0) ➕ `src/cascadia/TerminalControl/ScrollBarVisualStateManager.idl` (+8 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+3 -3) 📝 `src/cascadia/TerminalControl/TermControl.xaml` (+5 -0) 📝 `src/cascadia/TerminalControl/TerminalControlLib.vcxproj` (+8 -1) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+6 -2) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+3 -2) </details> ### 📄 Description This fixes #3454 by adding support for an "always" mode for the scroll bar. This change uses a custom VisualStateManager to keep the scroll bar from collapsing if the profile is using the 'always' setting. ## Validation Steps Performed Tried updating settings.json directly and using the UI and making sure the scroll bar behaves as expected. Closes #3454 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:32 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29905