starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-23 23:45:08 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Cannot cancel gitbash running task #2991

New Issue
Closed
opened 2026-01-30 23:10:21 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 23:10:21 +00:00
Owner
Copy Link

Originally created by @samuelkdavis-mccarthyfinch on GitHub (Jul 30, 2019).

Environment

Windows build number: 18362.239
Windows Terminal version (if applicable): 0.2.1.18831.0

Any other software?

Git bash with the profile:
        {
            "acrylicOpacity" : 0.5,
            "closeOnExit" : true,
            "colorScheme" : "Campbell",
            "commandline" : "C:\\Program Files\\Git\\bin\\bash.exe",
            "icon" : "C:\\Program Files\\Git\\mingw64\\share\\git\\git-for-windows.ico",
            "name" : "Git Bash",
            "startingDirectory" : "%HOMEDRIVE%%HOMEPATH%",
            "cursorColor" : "#FFFFFF",
            "cursorShape" : "bar",
            "fontFace" : "Consolas",
            "fontSize" : 10,
            "guid" : "{9a3f80c4-d840-4781-a7d3-84f6c7c9dd7c}",
            "historySize" : 9001,
            "padding" : "0, 0, 0, 0",
            "snapOnInput" : true,
            "useAcrylic" : false
        },

Python 3.6.8-amd64

Steps to reproduce

Set up gitbash with the json above. Run a long-running task in the current window. Ctrl+c doesn't kill the task

Expected behavior

ctrl+c should kill the task

Actual behavior

Cannot regain control over the current window.

Originally created by @samuelkdavis-mccarthyfinch on GitHub (Jul 30, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 18362.239 Windows Terminal version (if applicable): 0.2.1.18831.0 Any other software? Git bash with the profile: { "acrylicOpacity" : 0.5, "closeOnExit" : true, "colorScheme" : "Campbell", "commandline" : "C:\\Program Files\\Git\\bin\\bash.exe", "icon" : "C:\\Program Files\\Git\\mingw64\\share\\git\\git-for-windows.ico", "name" : "Git Bash", "startingDirectory" : "%HOMEDRIVE%%HOMEPATH%", "cursorColor" : "#FFFFFF", "cursorShape" : "bar", "fontFace" : "Consolas", "fontSize" : 10, "guid" : "{9a3f80c4-d840-4781-a7d3-84f6c7c9dd7c}", "historySize" : 9001, "padding" : "0, 0, 0, 0", "snapOnInput" : true, "useAcrylic" : false }, Python 3.6.8-amd64 ``` # Steps to reproduce Set up gitbash with the json above. Run a long-running task in the current window. Ctrl+c doesn't kill the task # Expected behavior ctrl+c should kill the task # Actual behavior Cannot regain control over the current window.
claunia added the Needs-TriageResolution-ExternalNeeds-Tag-Fix labels 2026-01-30 23:10:21 +00:00
claunia commented 2026-01-30 23:10:22 +00:00
Author
Owner
Copy Link

@samuelkdavis-mccarthyfinch commented on GitHub (Jul 30, 2019):

Opening a new gitbash tab, running ps to find the process id, then running kill 1234123 fixes the first tab

@samuelkdavis-mccarthyfinch commented on GitHub (Jul 30, 2019): Opening a new gitbash tab, running `ps` to find the process id, then running `kill 1234123` fixes the first tab
claunia commented 2026-01-30 23:10:22 +00:00
Author
Owner
Copy Link

@samuelkdavis-mccarthyfinch commented on GitHub (Jul 30, 2019):

This could be the cause...

https://stackoverflow.com/questions/45987985/asyncio-loops-add-signal-handler-in-windows

@samuelkdavis-mccarthyfinch commented on GitHub (Jul 30, 2019): This could be the cause... https://stackoverflow.com/questions/45987985/asyncio-loops-add-signal-handler-in-windows
claunia commented 2026-01-30 23:10:23 +00:00
Author
Owner
Copy Link

@samuelkdavis-mccarthyfinch commented on GitHub (Jul 30, 2019):

After a bit of investigation, it does seem to be an issue specifically with asyncio. I'm not sure if there's anything the terminal can do to regain control from runaway asyncio loops. Feel free to close this if there aren't any viable ways to control this from a terminal level.

@samuelkdavis-mccarthyfinch commented on GitHub (Jul 30, 2019): After a bit of investigation, it does seem to be an issue specifically with asyncio. I'm not sure if there's anything the terminal can do to regain control from runaway asyncio loops. Feel free to close this if there aren't any viable ways to control this from a terminal level.
claunia commented 2026-01-30 23:10:23 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 30, 2019):

Yea, this looks like it's out of our control. Fundamentally, the terminal is just a frontend for the Console API, so asynchio would need to find a better way to deal with this.

I'm kinda surprised they don't implement a windows-specific version of add_signal_handler that adds a ConsoleCtrlEvent handler, but I don't really know the specifcs of why they may have chosen not to do that.

@zadjii-msft commented on GitHub (Jul 30, 2019): Yea, this looks like it's out of our control. Fundamentally, the terminal is just a frontend for the Console API, so asynchio would need to find a better way to deal with this. I'm kinda surprised they don't implement a windows-specific version of `add_signal_handler` that adds a ConsoleCtrlEvent handler, but I don't really know the specifcs of why they may have chosen not to do that.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2991
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?