[PR #14092] [MERGED] Generally tidy the Commandline class #29925

Open
opened 2026-01-31 09:37:39 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14092
Author: @SiliconA-Z
Created: 9/27/2022
Status: Merged
Merged: 10/12/2022
Merged by: @undefined

Base: mainHead: static


📝 Commits (4)

📊 Changes

3 files changed (+16 additions, -22 deletions)

View changed files

📝 src/host/cmdline.cpp (+13 -19)
📝 src/host/cmdline.h (+2 -2)
📝 src/host/scrolling.cpp (+1 -1)

📄 Description

This pull request adds a couple const keywords, simplifies a bit of boolean logic,
adds the static keyword to Commandline::IsEditLineEmpty, and a couple more things.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14092 **Author:** [@SiliconA-Z](https://github.com/SiliconA-Z) **Created:** 9/27/2022 **Status:** ✅ Merged **Merged:** 10/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `static` --- ### 📝 Commits (4) - [`6eb868c`](https://github.com/microsoft/terminal/commit/6eb868c19dcf4030fa46e1e171e71b84acc03b3d) Make IsEditLineEmpty static - [`f18a62d`](https://github.com/microsoft/terminal/commit/f18a62d3c9f6ec50cd201c729b040eb29e0d5b90) Do suggested refactors - [`a839177`](https://github.com/microsoft/terminal/commit/a839177cd44e799071ae70985a2959e5a419adbb) Add braces back - [`2a8bb91`](https://github.com/microsoft/terminal/commit/2a8bb91bfd2f9c9818263707ee63832c081e75cb) Update src/host/cmdline.cpp ### 📊 Changes **3 files changed** (+16 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/host/cmdline.cpp` (+13 -19) 📝 `src/host/cmdline.h` (+2 -2) 📝 `src/host/scrolling.cpp` (+1 -1) </details> ### 📄 Description This pull request adds a couple `const` keywords, simplifies a bit of boolean logic, adds the `static` keyword to `Commandline::IsEditLineEmpty`, and a couple more things. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:39 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29925