[PR #14093] [MERGED] Reject illegal paths in OSC 9;9 #29929

Open
opened 2026-01-31 09:37:40 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14093
Author: @DHowett
Created: 9/27/2022
Status: Merged
Merged: 9/28/2022
Merged by: @DHowett

Base: mainHead: dev/duhowett/osc9001


📝 Commits (5)

📊 Changes

4 files changed (+81 additions, -31 deletions)

View changed files

📝 src/cascadia/UnitTests_TerminalCore/TerminalApiTest.cpp (+21 -13)
📝 src/inc/til/string.h (+38 -11)
📝 src/terminal/adapter/adaptDispatch.cpp (+10 -7)
📝 src/til/ut_til/string.cpp (+12 -0)

📄 Description

closes #12378


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14093 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 9/27/2022 **Status:** ✅ Merged **Merged:** 9/28/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/osc9001` --- ### 📝 Commits (5) - [`7394bb2`](https://github.com/microsoft/terminal/commit/7394bb261d4e684db691aab64eda75c6e56de874) Strip out non-path characters in OSC 9;9 - [`125220c`](https://github.com/microsoft/terminal/commit/125220c365709c537668097b4bfc48bd24d2dabe) Actually just reject it, why not - [`301d6e8`](https://github.com/microsoft/terminal/commit/301d6e89201a06e15a222605d88b4a86d26fd0e8) pass analysis too - [`aef72e7`](https://github.com/microsoft/terminal/commit/aef72e7e1566a10698c5da635fe5da67bf1253c3) Fix the invalid CWD tests - [`858ce97`](https://github.com/microsoft/terminal/commit/858ce976a72bcfb01e5e864a20b156c199bf1976) and, format ### 📊 Changes **4 files changed** (+81 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/UnitTests_TerminalCore/TerminalApiTest.cpp` (+21 -13) 📝 `src/inc/til/string.h` (+38 -11) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+10 -7) 📝 `src/til/ut_til/string.cpp` (+12 -0) </details> ### 📄 Description closes #12378 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:40 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29929