[PR #14180] [MERGED] Make SUI breadcrumb readable by screen readers #29975

Open
opened 2026-01-31 09:37:57 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14180
Author: @carlos-zamora
Created: 10/11/2022
Status: ✅ Merged
Merged: 10/12/2022
Merged by: @undefined

Base: main ← Head: dev/cazamor/a11y/sui-breadcrumb-not-read


📝 Commits (1)

  • 1d34f59 Make SUI breadcrumb readable by screen readers

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/MainPage.h (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.idl (+1 -1)

📄 Description

The breadcrumbs in the SUI were not readable by screen readers because they are represented as a button with a text block inside of it. Turns out, if you make the DataTemplate's item IStringable (meaning it has a ToString()), it all magically works! Allowing the screen reader to read the button as text.

Closes #13826


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14180 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 10/11/2022 **Status:** ✅ Merged **Merged:** 10/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/a11y/sui-breadcrumb-not-read` --- ### 📝 Commits (1) - [`1d34f59`](https://github.com/microsoft/terminal/commit/1d34f596bb4fa224159b726e68dd4647bc253cdd) Make SUI breadcrumb readable by screen readers ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/MainPage.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.idl` (+1 -1) </details> ### 📄 Description The breadcrumbs in the SUI were not readable by screen readers because they are represented as a button with a text block inside of it. Turns out, if you make the DataTemplate's item `IStringable` (meaning it has a `ToString()`), it all magically works! Allowing the screen reader to read the button as text. Closes #13826 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:57 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29975