[PR #14179] [CLOSED] Introduce UIA movement/expansion by page #29977

Open
opened 2026-01-31 09:37:58 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14179
Author: @carlos-zamora
Created: 10/11/2022
Status: Closed

Base: mainHead: dev/cazamor/a11y/nav-by-page


📝 Commits (6)

  • 3402710 Expand by page
  • 66d7f56 Move endpoint by page
  • 9bc13bf Write tests
  • 7017fef pass MovementAtExclusiveEnd tests
  • f80a23c 13 of 85 tests failing (all non-degenerate cases)
  • 59f2bc3 Migrate spelling-0.0.21 changes from main

📊 Changes

19 files changed (+2483 additions, -971 deletions)

View changed files

📝 .github/actions/spelling/README.md (+1 -0)
📝 .github/actions/spelling/advice.md (+1 -1)
📝 .github/actions/spelling/allow/allow.txt (+7 -2)
📝 .github/actions/spelling/allow/apis.txt (+5 -4)
.github/actions/spelling/candidate.patterns (+523 -0)
📝 .github/actions/spelling/excludes.txt (+27 -11)
📝 .github/actions/spelling/expect/alphabet.txt (+0 -7)
📝 .github/actions/spelling/expect/expect.txt (+89 -607)
📝 .github/actions/spelling/expect/web.txt (+0 -2)
📝 .github/actions/spelling/line_forbidden.patterns (+28 -2)
📝 .github/actions/spelling/patterns/patterns.txt (+56 -1)
📝 .github/actions/spelling/reject.txt (+4 -23)
📝 .github/workflows/spelling2.yml (+96 -8)
📝 src/interactivity/win32/ut_interactivity_win32/GeneratedUiaTextRangeMovementTests.g.cpp (+1276 -248)
📝 src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp (+53 -0)
📝 src/types/UiaTextRangeBase.cpp (+158 -0)
📝 src/types/UiaTextRangeBase.hpp (+6 -0)
📝 tools/TestTableWriter/GenerateTests.ps1 (+13 -0)
📝 tools/TestTableWriter/UiaTests.csv (+140 -55)

📄 Description

Summary of the Pull Request

This adds support for the "Page" text unit in UiaTextRange. In terminals, the viewport will be used as the size of a "page". This should feel natural since "page up" and "page down" have been supported for quite some time. By extension, "expanding" to the page should return the same as getting the visible range.

This includes more UIA Table Tests that were manually verified and constructed from direct testing with Microsoft Word.

PR Checklist

Detailed Description of the Pull Request / Additional comments

(Coming soon)

Validation Steps Performed

(Coming soon)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14179 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 10/11/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/cazamor/a11y/nav-by-page` --- ### 📝 Commits (6) - [`3402710`](https://github.com/microsoft/terminal/commit/340271075dbb9554303ac54bb7c66acb25eda27a) Expand by page - [`66d7f56`](https://github.com/microsoft/terminal/commit/66d7f56b29b174ab5d86e77effa12d801bc8eebe) Move endpoint by page - [`9bc13bf`](https://github.com/microsoft/terminal/commit/9bc13bffd82422fb3c05cfaedf6a69bf3d53daf9) Write tests - [`7017fef`](https://github.com/microsoft/terminal/commit/7017feff8ba33ee7cb9f4f3fb34a4a4846d959f6) pass MovementAtExclusiveEnd tests - [`f80a23c`](https://github.com/microsoft/terminal/commit/f80a23ccb3a119efaaa19c42848037880c1ebaf1) 13 of 85 tests failing (all non-degenerate cases) - [`59f2bc3`](https://github.com/microsoft/terminal/commit/59f2bc383e7619288e05be24df4dbafd32279154) Migrate spelling-0.0.21 changes from main ### 📊 Changes **19 files changed** (+2483 additions, -971 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/README.md` (+1 -0) 📝 `.github/actions/spelling/advice.md` (+1 -1) 📝 `.github/actions/spelling/allow/allow.txt` (+7 -2) 📝 `.github/actions/spelling/allow/apis.txt` (+5 -4) ➕ `.github/actions/spelling/candidate.patterns` (+523 -0) 📝 `.github/actions/spelling/excludes.txt` (+27 -11) 📝 `.github/actions/spelling/expect/alphabet.txt` (+0 -7) 📝 `.github/actions/spelling/expect/expect.txt` (+89 -607) 📝 `.github/actions/spelling/expect/web.txt` (+0 -2) 📝 `.github/actions/spelling/line_forbidden.patterns` (+28 -2) 📝 `.github/actions/spelling/patterns/patterns.txt` (+56 -1) 📝 `.github/actions/spelling/reject.txt` (+4 -23) 📝 `.github/workflows/spelling2.yml` (+96 -8) 📝 `src/interactivity/win32/ut_interactivity_win32/GeneratedUiaTextRangeMovementTests.g.cpp` (+1276 -248) 📝 `src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp` (+53 -0) 📝 `src/types/UiaTextRangeBase.cpp` (+158 -0) 📝 `src/types/UiaTextRangeBase.hpp` (+6 -0) 📝 `tools/TestTableWriter/GenerateTests.ps1` (+13 -0) 📝 `tools/TestTableWriter/UiaTests.csv` (+140 -55) </details> ### 📄 Description ## Summary of the Pull Request This adds support for the "Page" text unit in UiaTextRange. In terminals, the viewport will be used as the size of a "page". This should feel natural since "page up" and "page down" have been supported for quite some time. By extension, "expanding" to the page should return the same as getting the visible range. This includes more UIA Table Tests that were manually verified and constructed from direct testing with Microsoft Word. ## PR Checklist * [X] Closes #13756 * [ ] Tests added/passed ## Detailed Description of the Pull Request / Additional comments (Coming soon) ## Validation Steps Performed (Coming soon) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:58 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29977