starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14193] [MERGED] Disable acrylic material (temporarily) when opacity is set to 100% #29987

New Issue
Open
opened 2026-01-31 09:38:02 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:02 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14193
Author: @JerBast
Created: 10/12/2022
Status: ✅ Merged
Merged: 10/27/2022
Merged by: @undefined

Base: main ← Head: 12880

📝 Commits (5)

  • c983574 Disable acrylic (temporarily) when opacity set to 100%
  • 87da92f Reflect behavioral changes in tests for 100% opacity
  • a0b526e Use clamped value in comparison for consistency
  • 4d721b1 Use more consistent approach for updating UseAcrylic and Opacity
  • 7fcdff2 Remove redundant UseAcrylic check from _isBackgroundTransparent due to new constraints

📊 Changes

3 files changed (+9 additions, -18 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+6 -14)
📝 src/cascadia/UnitTests_Control/ControlCoreTests.cpp (+1 -2)
📝 src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp (+2 -2)

📄 Description

If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings).

Validation Steps Performed

I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11.

Steps:

  1. Start with 100% opacity and acrylic material enabled.
  2. Decrease opacity and observe acrylic effect.
  3. Increase opacity back to 100% and disable the acrylic effect.
  4. Decrease opacity and notice that acrylic effect is no longer there.

Closes #12880

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14193 **Author:** [@JerBast](https://github.com/JerBast) **Created:** 10/12/2022 **Status:** ✅ Merged **Merged:** 10/27/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `12880` --- ### 📝 Commits (5) - [`c983574`](https://github.com/microsoft/terminal/commit/c9835741c565a5e8f6b5cd343e17c4757fc1f107) Disable acrylic (temporarily) when opacity set to 100% - [`87da92f`](https://github.com/microsoft/terminal/commit/87da92f03606d86c0d8a27e0fb564ec993e8bb75) Reflect behavioral changes in tests for 100% opacity - [`a0b526e`](https://github.com/microsoft/terminal/commit/a0b526ef112fc2e1f5dfda0a432d1b1f8f62bcc4) Use clamped value in comparison for consistency - [`4d721b1`](https://github.com/microsoft/terminal/commit/4d721b107c730666295968409097884b98521a8f) Use more consistent approach for updating UseAcrylic and Opacity - [`7fcdff2`](https://github.com/microsoft/terminal/commit/7fcdff287a662fef9de0857c8596aa2b07a7d17b) Remove redundant UseAcrylic check from _isBackgroundTransparent due to new constraints ### 📊 Changes **3 files changed** (+9 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+6 -14) 📝 `src/cascadia/UnitTests_Control/ControlCoreTests.cpp` (+1 -2) 📝 `src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp` (+2 -2) </details> ### 📄 Description If the opacity is set to 100%, the background becomes solid instead of 'fully opaque acrylic'. If the opacity is below 100% the acrylic material is re-enabled (depending on the user's settings). ## Validation Steps Performed I updated two unit tests to reflect the change in behavior and manually tested the transition from <100% opacity to 100% opacity (and vice versa) on win11. Steps: 1. Start with 100% opacity and acrylic material enabled. 2. Decrease opacity and observe acrylic effect. 3. Increase opacity back to 100% and disable the acrylic effect. 4. Decrease opacity and notice that acrylic effect is no longer there. Closes #12880 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:02 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29987
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?