starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14214] [MERGED] Skip DECPS/MIDI output on Ctrl+C/Break #29997

New Issue
Open
opened 2026-01-31 09:38:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:05 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14214
Author: @lhecker
Created: 10/13/2022
Status: ✅ Merged
Merged: 10/31/2022
Merged by: @DHowett

Base: main ← Head: dev/lhecker/fix-midi-freezes

📝 Commits (3)

  • fc3d134 Skip DECPS/MIDI output on Ctrl+C/Break
  • 8eba770 Simplify SetTimer, Fix x86 build
  • e5643c1 Address feedback

📊 Changes

12 files changed (+106 additions, -159 deletions)

View changed files

📝 src/audio/midi/MidiAudio.cpp (+19 -48)
📝 src/audio/midi/MidiAudio.hpp (+9 -18)
📝 src/audio/midi/precomp.h (+3 -1)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+33 -47)
📝 src/cascadia/TerminalControl/ControlCore.h (+3 -4)
📝 src/host/consoleInformation.cpp (+6 -26)
📝 src/host/globals.cpp (+4 -0)
📝 src/host/input.cpp (+20 -0)
📝 src/host/output.cpp (+0 -2)
📝 src/host/outputStream.cpp (+4 -11)
📝 src/host/server.h (+1 -2)
📝 src/interactivity/base/ServiceLocator.cpp (+4 -0)

📄 Description

Silent MIDI notes can be used to seemingly deny a user's input for long
durations (multiple minutes). This commit improves the situation by ignoring
all DECPS sequences for a second when Ctrl+C/Ctrl+Break is pressed.

Additionally it fixes a regression introduced in 666c446:
When we close a tab we need to unblock/shutdown MidiAudio early,
so that ConptyConnection::Close() can run down as fast as possible.

Validation Steps Performed

  • In pwsh in Windows Terminal 1.16 run while ($True) { echo "`e[3;8;3,~" }
    • Ctrl+C doesn't do anything ❎
    • Closing the tab doesn't do anything ❎
  • With these modifications in Windows Terminal:
    • Ctrl+C stops the output ✅
    • Closing the tab completes instantly ✅
  • With these modifications in OpenConsole:
    • Ctrl+C stops the output ✅
    • Closing the window completes instantly ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14214 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 10/13/2022 **Status:** ✅ Merged **Merged:** 10/31/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/lhecker/fix-midi-freezes` --- ### 📝 Commits (3) - [`fc3d134`](https://github.com/microsoft/terminal/commit/fc3d134877960e861e7cf4f1e9f843bd8e745aa6) Skip DECPS/MIDI output on Ctrl+C/Break - [`8eba770`](https://github.com/microsoft/terminal/commit/8eba770267203d3a7db5311f84010b3b7e44c09e) Simplify SetTimer, Fix x86 build - [`e5643c1`](https://github.com/microsoft/terminal/commit/e5643c1a8c66c0e0dfca17ac626fb2b583c603eb) Address feedback ### 📊 Changes **12 files changed** (+106 additions, -159 deletions) <details> <summary>View changed files</summary> 📝 `src/audio/midi/MidiAudio.cpp` (+19 -48) 📝 `src/audio/midi/MidiAudio.hpp` (+9 -18) 📝 `src/audio/midi/precomp.h` (+3 -1) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+33 -47) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+3 -4) 📝 `src/host/consoleInformation.cpp` (+6 -26) 📝 `src/host/globals.cpp` (+4 -0) 📝 `src/host/input.cpp` (+20 -0) 📝 `src/host/output.cpp` (+0 -2) 📝 `src/host/outputStream.cpp` (+4 -11) 📝 `src/host/server.h` (+1 -2) 📝 `src/interactivity/base/ServiceLocator.cpp` (+4 -0) </details> ### 📄 Description Silent MIDI notes can be used to seemingly deny a user's input for long durations (multiple minutes). This commit improves the situation by ignoring all DECPS sequences for a second when Ctrl+C/Ctrl+Break is pressed. Additionally it fixes a regression introduced in 666c446: When we close a tab we need to unblock/shutdown `MidiAudio` early, so that `ConptyConnection::Close()` can run down as fast as possible. ## Validation Steps Performed * In pwsh in Windows Terminal 1.16 run ``while ($True) { echo "`e[3;8;3,~" }`` * Ctrl+C doesn't do anything ❎ * Closing the tab doesn't do anything ❎ * With these modifications in Windows Terminal: * Ctrl+C stops the output ✅ * Closing the tab completes instantly ✅ * With these modifications in OpenConsole: * Ctrl+C stops the output ✅ * Closing the window completes instantly ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?