[PR #14224] [MERGED] Stop freeing BSTRs that do not belong to us #30006

Open
opened 2026-01-31 09:38:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14224
Author: @DHowett
Created: 10/14/2022
Status: ✅ Merged
Merged: 10/15/2022
Merged by: @undefined

Base: main ← Head: dev/duhowett/yeah


📝 Commits (1)

  • b5999bf Stop freeing BSTRs that do not belong to us (oops)

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+0 -2)

📄 Description

The BSTR arguments originate from COM calls who own them.
Found via AppVerifier.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14224 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 10/14/2022 **Status:** ✅ Merged **Merged:** 10/15/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/yeah` --- ### 📝 Commits (1) - [`b5999bf`](https://github.com/microsoft/terminal/commit/b5999bf37541f1c6847859dc4ef668c9ea5cf446) Stop freeing BSTRs that do not belong to us (oops) ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+0 -2) </details> ### 📄 Description The `BSTR` arguments originate from COM calls who own them. Found via AppVerifier. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30006