[PR #14217] [CLOSED] Add system menu support from SUI & read-only panes #30009

Open
opened 2026-01-31 09:38:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14217
Author: @carlos-zamora
Created: 10/13/2022
Status: Closed

Base: mainHead: dev/cazamor/a11y/system-menu-support


📝 Commits (2)

  • c636c1d [SUI] Add support for system menu
  • d45fe0f [Read-only panes] Add support for system menu

📊 Changes

9 files changed (+91 additions, -7 deletions)

View changed files

📝 src/cascadia/TerminalApp/IDirectKeyListener.idl (+2 -2)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -0)
📝 src/cascadia/TerminalControl/IDirectKeyListener.idl (+2 -2)
📝 src/cascadia/TerminalControl/TermControl.cpp (+2 -2)
src/cascadia/TerminalSettingsEditor/IDirectKeyListener.idl (+14 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+56 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.h (+8 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.idl (+5 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+1 -0)

📄 Description

Summary of the Pull Request

Adds support for the system menu to appear from the Settings UI and read-only panes.

PR Checklist

Closes #11970

Detailed Description of the Pull Request / Additional comments

This is another case of needing the DirectKeyListener. Alt+Space just doesn't go through the normal key event handler, so we needed to add support for it in both of these places.

Validation Steps Performed

  • Tested ALT+SPACE from settings UI
  • Tested ALT+SPACE from read-only pane

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14217 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 10/13/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/cazamor/a11y/system-menu-support` --- ### 📝 Commits (2) - [`c636c1d`](https://github.com/microsoft/terminal/commit/c636c1da51b910d9cd4d3c728e7f70eefe2e5594) [SUI] Add support for system menu - [`d45fe0f`](https://github.com/microsoft/terminal/commit/d45fe0f8e091f794d2fc7f03b4b438dc8c6eee98) [Read-only panes] Add support for system menu ### 📊 Changes **9 files changed** (+91 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/IDirectKeyListener.idl` (+2 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -0) 📝 `src/cascadia/TerminalControl/IDirectKeyListener.idl` (+2 -2) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+2 -2) ➕ `src/cascadia/TerminalSettingsEditor/IDirectKeyListener.idl` (+14 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+56 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.h` (+8 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.idl` (+5 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds support for the system menu to appear from the Settings UI and read-only panes. ## PR Checklist Closes #11970 ## Detailed Description of the Pull Request / Additional comments This is another case of needing the DirectKeyListener. Alt+Space just doesn't go through the normal key event handler, so we needed to add support for it in both of these places. ## Validation Steps Performed - [X] Tested ALT+SPACE from settings UI - [X] Tested ALT+SPACE from read-only pane --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30009