starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14255] [MERGED] Implement cell size customizations #30028

New Issue
Open
opened 2026-01-31 09:38:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:15 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14255
Author: @lhecker
Created: 10/19/2022
Status: ✅ Merged
Merged: 2/14/2023
Merged by: @lhecker

Base: main ← Head: dev/lhecker/3498-line-heights

📝 Commits (8)

  • aaec2a5 Implement cell size customizations
  • ba8e165 Fix unit tests
  • f6e730e Address parts of the feedback
  • 6bbc1cd Merge remote-tracking branch 'origin/main' into dev/lhecker/3498-line-heights
  • 9554470 Merge remote-tracking branch 'origin/main' into dev/lhecker/3498-line-heights
  • 504f483 Address feedback
  • 17f8e47 Fix config saving
  • dd34a30 Merge remote-tracking branch 'origin/main' into dev/lhecker/3498-line-heights

📊 Changes

28 files changed (+348 additions, -64 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+15 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+4 -0)
📝 src/cascadia/TerminalControl/ControlCore.h (+2 -0)
📝 src/cascadia/TerminalControl/IControlSettings.idl (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+80 -4)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+9 -12)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+16 -1)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+16 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsModel/FontConfig.cpp (+0 -5)
📝 src/cascadia/TerminalSettingsModel/FontConfig.h (+0 -1)
📝 src/cascadia/TerminalSettingsModel/FontConfig.idl (+2 -1)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+3 -1)
📝 src/cascadia/TerminalSettingsModel/Profile.cpp (+2 -4)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+8 -5)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+2 -0)
📝 src/cascadia/inc/ControlProperties.h (+2 -0)
📝 src/renderer/atlas/AtlasEngine.api.cpp (+15 -12)
📝 src/renderer/atlas/AtlasEngine.cpp (+8 -0)

...and 8 more files

📄 Description

Does what it says in the title. After this commit you can customize the height
and width of the terminal's cells. This commit supports parts of CSS'
<length-percentage> data type: Font-size relative sizes as multiples (1.2),
percentage (120%), or advance-width relative (1.2ch), as well as absolute
sizes in CSS pixels (px) or points (pt).

This PR is neither bug free in DxEngine, nor in AtlasEngine.
The former fails to implement glyph advance corrections (for instance #9381),
as well as disallowing glyphs to overlap rows. The latter has the same
overlap issue, but more severely as it tries to shrink glyphs to fit in.

Closes #3498
Closes #14068

Validation Steps Performed

  • Setting height to 1 creates 12pt tall rows ✅
  • Setting height to 1ch creates square cells ✅
  • Setting width to 1 creates square cells ✅
  • Setting width or height to Npx or Npt works ✅
  • Trailing zeroes are trimmed properly during serialization ✅
  • Patching the PR to allow >100 line heights and entering "100.123456"
    displays 6 fractional digits ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14255 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 10/19/2022 **Status:** ✅ Merged **Merged:** 2/14/2023 **Merged by:** [@lhecker](https://github.com/lhecker) **Base:** `main` ← **Head:** `dev/lhecker/3498-line-heights` --- ### 📝 Commits (8) - [`aaec2a5`](https://github.com/microsoft/terminal/commit/aaec2a50e002dacde6b4f922f552c963afd9da67) Implement cell size customizations - [`ba8e165`](https://github.com/microsoft/terminal/commit/ba8e1650a19d2a7338cd35116223e3b4df4acb62) Fix unit tests - [`f6e730e`](https://github.com/microsoft/terminal/commit/f6e730ecfb4032112f81444164d1ab9bdfaa6f26) Address parts of the feedback - [`6bbc1cd`](https://github.com/microsoft/terminal/commit/6bbc1cd28f6708e57789e9037fd1f2d56bfad3f9) Merge remote-tracking branch 'origin/main' into dev/lhecker/3498-line-heights - [`9554470`](https://github.com/microsoft/terminal/commit/9554470355595f0aee1c3208cb0b83b741291745) Merge remote-tracking branch 'origin/main' into dev/lhecker/3498-line-heights - [`504f483`](https://github.com/microsoft/terminal/commit/504f483586c97e9461a5b6908475234748abca89) Address feedback - [`17f8e47`](https://github.com/microsoft/terminal/commit/17f8e4705597c776e16ac53477a67006d85f3067) Fix config saving - [`dd34a30`](https://github.com/microsoft/terminal/commit/dd34a30873da5858039e87ceeb75bdc09186b952) Merge remote-tracking branch 'origin/main' into dev/lhecker/3498-line-heights ### 📊 Changes **28 files changed** (+348 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+15 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+4 -0) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+2 -0) 📝 `src/cascadia/TerminalControl/IControlSettings.idl` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+80 -4) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+9 -12) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+16 -1) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+16 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/FontConfig.cpp` (+0 -5) 📝 `src/cascadia/TerminalSettingsModel/FontConfig.h` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/FontConfig.idl` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+3 -1) 📝 `src/cascadia/TerminalSettingsModel/Profile.cpp` (+2 -4) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+8 -5) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+2 -0) 📝 `src/cascadia/inc/ControlProperties.h` (+2 -0) 📝 `src/renderer/atlas/AtlasEngine.api.cpp` (+15 -12) 📝 `src/renderer/atlas/AtlasEngine.cpp` (+8 -0) _...and 8 more files_ </details> ### 📄 Description Does what it says in the title. After this commit you can customize the height and width of the terminal's cells. This commit supports parts of CSS' `<length-percentage>` data type: Font-size relative sizes as multiples (`1.2`), percentage (`120%`), or advance-width relative (`1.2ch`), as well as absolute sizes in CSS pixels (`px`) or points (`pt`). This PR is neither bug free in DxEngine, nor in AtlasEngine. The former fails to implement glyph advance corrections (for instance #9381), as well as disallowing glyphs to overlap rows. The latter has the same overlap issue, but more severely as it tries to shrink glyphs to fit in. Closes #3498 Closes #14068 ## Validation Steps Performed * Setting `height` to `1` creates 12pt tall rows ✅ * Setting `height` to `1ch` creates square cells ✅ * Setting `width` to `1` creates square cells ✅ * Setting `width` or `height` to `Npx` or `Npt` works ✅ * Trailing zeroes are trimmed properly during serialization ✅ * Patching the PR to allow >100 line heights and entering "100.123456" displays 6 fractional digits ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30028
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?