[PR #14358] [MERGED] Fix VtIoTests for debug builds #30064

Open
opened 2026-01-31 09:38:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14358
Author: @lhecker
Created: 11/9/2022
Status: ✅ Merged
Merged: 11/10/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/unit-test-fixup


📝 Commits (1)

  • 39623de Fix VtIoTests for debug builds

📊 Changes

1 file changed (+11 additions, -4 deletions)

View changed files

📝 src/host/ut_host/VtIoTests.cpp (+11 -4)

📄 Description

1774cfd added a debug assertion in CreateIoHandlers which broke this test.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14358 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 11/9/2022 **Status:** ✅ Merged **Merged:** 11/10/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/unit-test-fixup` --- ### 📝 Commits (1) - [`39623de`](https://github.com/microsoft/terminal/commit/39623de260da9ca154500c42f6bc0a1d30f9385d) Fix VtIoTests for debug builds ### 📊 Changes **1 file changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/host/ut_host/VtIoTests.cpp` (+11 -4) </details> ### 📄 Description 1774cfd added a debug assertion in `CreateIoHandlers` which broke this test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30064