starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14427] [MERGED] Merge IBaseData, IRenderData and IUiaData #30085

New Issue
Open
opened 2026-01-31 09:38:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:34 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14427
Author: @lhecker
Created: 11/22/2022
Status: ✅ Merged
Merged: 12/5/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/merge-render-data

📝 Commits (3)

  • 569b161 Merge IBaseData, IRenderData and IUiaData
  • 3a46fc2 Merge remote-tracking branch 'origin/main' into dev/lhecker/merge-render-data
  • 8115dff Address feedback

📊 Changes

32 files changed (+102 additions, -226 deletions)

View changed files

📝 src/buffer/out/search.cpp (+20 -20)
📝 src/buffer/out/search.h (+5 -6)
📝 src/cascadia/PublicTerminalCore/HwndTerminal.cpp (+2 -2)
📝 src/cascadia/PublicTerminalCore/HwndTerminal.hpp (+1 -1)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+2 -2)
📝 src/cascadia/TerminalControl/ControlCore.h (+1 -1)
📝 src/cascadia/TerminalControl/ControlInteractivity.cpp (+2 -2)
📝 src/cascadia/TerminalControl/ControlInteractivity.h (+1 -1)
📝 src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -9)
📝 src/host/renderData.cpp (+0 -7)
📝 src/host/renderData.hpp (+1 -10)
📝 src/host/ut_host/VtIoTests.cpp (+1 -1)
📝 src/interactivity/win32/screenInfoUiaProvider.cpp (+1 -1)
📝 src/interactivity/win32/screenInfoUiaProvider.hpp (+1 -1)
📝 src/interactivity/win32/uiaTextRange.cpp (+4 -4)
📝 src/interactivity/win32/uiaTextRange.hpp (+4 -4)
📝 src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp (+1 -1)
📝 src/interactivity/win32/windowUiaProvider.cpp (+3 -3)
📝 src/renderer/inc/IRenderData.hpp (+23 -17)

...and 12 more files

📄 Description

My goal is to make IRenderData "snapshottable", so that we
can render a frame of text without holding the console lock.
To facilitate this, this commit merges our 3 data interfaces
into one. It includes no actual changes apart from renames.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14427 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 11/22/2022 **Status:** ✅ Merged **Merged:** 12/5/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/merge-render-data` --- ### 📝 Commits (3) - [`569b161`](https://github.com/microsoft/terminal/commit/569b161a15d391cce3ed2f1f417a7855562c6364) Merge IBaseData, IRenderData and IUiaData - [`3a46fc2`](https://github.com/microsoft/terminal/commit/3a46fc247193ac263e78bf88b5e2c874065a1d2d) Merge remote-tracking branch 'origin/main' into dev/lhecker/merge-render-data - [`8115dff`](https://github.com/microsoft/terminal/commit/8115dff0a4c731e5d7b15b6da5ddd04c0f71532c) Address feedback ### 📊 Changes **32 files changed** (+102 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/search.cpp` (+20 -20) 📝 `src/buffer/out/search.h` (+5 -6) 📝 `src/cascadia/PublicTerminalCore/HwndTerminal.cpp` (+2 -2) 📝 `src/cascadia/PublicTerminalCore/HwndTerminal.hpp` (+1 -1) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+2 -2) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+1 -1) 📝 `src/cascadia/TerminalControl/ControlInteractivity.cpp` (+2 -2) 📝 `src/cascadia/TerminalControl/ControlInteractivity.h` (+1 -1) 📝 `src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -9) 📝 `src/host/renderData.cpp` (+0 -7) 📝 `src/host/renderData.hpp` (+1 -10) 📝 `src/host/ut_host/VtIoTests.cpp` (+1 -1) 📝 `src/interactivity/win32/screenInfoUiaProvider.cpp` (+1 -1) 📝 `src/interactivity/win32/screenInfoUiaProvider.hpp` (+1 -1) 📝 `src/interactivity/win32/uiaTextRange.cpp` (+4 -4) 📝 `src/interactivity/win32/uiaTextRange.hpp` (+4 -4) 📝 `src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp` (+1 -1) 📝 `src/interactivity/win32/windowUiaProvider.cpp` (+3 -3) 📝 `src/renderer/inc/IRenderData.hpp` (+23 -17) _...and 12 more files_ </details> ### 📄 Description My goal is to make `IRenderData` "snapshottable", so that we can render a frame of text without holding the console lock. To facilitate this, this commit merges our 3 data interfaces into one. It includes no actual changes apart from renames. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30085
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?