starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14455] [MERGED] Update to check-spelling v0.0.21 #30094

New Issue
Open
opened 2026-01-31 09:38:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14455
Author: @jsoref
Created: 11/28/2022
Status: ✅ Merged
Merged: 11/28/2022
Merged by: @DHowett

Base: main ← Head: check-spelling-0.0.21

📝 Commits (9)

📊 Changes

34 files changed (+871 additions, -707 deletions)

View changed files

📝 .github/actions/spelling/README.md (+1 -0)
📝 .github/actions/spelling/advice.md (+1 -1)
📝 .github/actions/spelling/allow/allow.txt (+6 -2)
➕ .github/actions/spelling/candidate.patterns (+523 -0)
📝 .github/actions/spelling/excludes.txt (+27 -11)
📝 .github/actions/spelling/expect/alphabet.txt (+0 -7)
📝 .github/actions/spelling/expect/expect.txt (+87 -608)
📝 .github/actions/spelling/expect/web.txt (+0 -2)
📝 .github/actions/spelling/line_forbidden.patterns (+28 -2)
📝 .github/actions/spelling/patterns/patterns.txt (+56 -1)
📝 .github/actions/spelling/reject.txt (+4 -23)
📝 .github/workflows/spelling2.yml (+96 -8)
📝 build/pgo/Terminal.PGO.props (+4 -4)
📝 doc/ConsoleHostSettings.md (+1 -1)
📝 doc/specs/#492 - Default Terminal/spec.md (+1 -1)
📝 doc/specs/#4993 - Keyboard Selection/Keyboard-Selection.md (+1 -1)
📝 doc/specs/#754 - Cascading Default Settings.md (+4 -4)
📝 doc/specs/#885 - Terminal Settings Model/#885 - Terminal Settings Model.md (+2 -2)
📝 scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj (+1 -1)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj (+1 -1)

...and 14 more files

📄 Description

Upgrades check-spelling to v0.0.21

The command to apply changes should now work on Windows (it requires
Perl, but I believe that's more or less present most of the time, and it
should walk you through the rest of the required tools).

There are a bunch of new features, the most important here are probably
being able to update the metadata from Windows. (If it doesn't work,
please @ me).

Also, candidate.patterns will automatically suggest patterns. You can
see them in patterns.txt, e.g.:

# Automatically suggested patterns
# hit-count: 3831 file-count: 582
# IServiceProvider
\bI(?=(?:[A-Z][a-z]{2,})+\b)

The metadata bits (the hit count/file count) don't have to be retained
(I hope they'll be useful in deciding whether/or not to add a pattern,
i.e. "how applicable is it?"), the comment hinting at what the pattern
does is probably worth retaining.

We've been using more or less this version for a while internally
(including talk-to-bot, and, I do have a pattern that could be used to
let people use that in forks, but, I'm going to skip that for now).

This weekend, I did some cleanup for act (to run check-spelling
locally), and some minor polish.

You can see the runs I made in
https://github.com/check-spelling/terminal/actions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14455 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 11/28/2022 **Status:** ✅ Merged **Merged:** 11/28/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `check-spelling-0.0.21` --- ### 📝 Commits (9) - [`32953fb`](https://github.com/microsoft/terminal/commit/32953fb7da6439a743d82fa04a10d811edf6c997) spelling: calculate - [`53b8740`](https://github.com/microsoft/terminal/commit/53b87402b194a675db545dd4106240eda6fdd733) spelling: copies - [`4970367`](https://github.com/microsoft/terminal/commit/4970367ea89bc28b65b9c4f8d96b2ebe88c8575e) spelling: finish - [`73b8dd2`](https://github.com/microsoft/terminal/commit/73b8dd2f61744692a439f558f8a4c7383ba4d97b) spelling: hard-code - [`e0fa24c`](https://github.com/microsoft/terminal/commit/e0fa24cfb879d3b4b67f49dc84ba8d144f712ac3) spelling: in-between - [`020b8f9`](https://github.com/microsoft/terminal/commit/020b8f98e22b04e423b6dfb2f20ebb89f654c52b) spelling: targeting - [`f2d6a22`](https://github.com/microsoft/terminal/commit/f2d6a22dce2a0ad2d1c5795c532aed25245ee812) spelling: terminal - [`016b54e`](https://github.com/microsoft/terminal/commit/016b54e58479a54c4db7538dbf6ce2fa9524cd5f) spelling: version - [`78b83fb`](https://github.com/microsoft/terminal/commit/78b83fba3fafe004879b661787812fc8bb773317) Upgrade check-spelling to v0.0.21 ### 📊 Changes **34 files changed** (+871 additions, -707 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/README.md` (+1 -0) 📝 `.github/actions/spelling/advice.md` (+1 -1) 📝 `.github/actions/spelling/allow/allow.txt` (+6 -2) ➕ `.github/actions/spelling/candidate.patterns` (+523 -0) 📝 `.github/actions/spelling/excludes.txt` (+27 -11) 📝 `.github/actions/spelling/expect/alphabet.txt` (+0 -7) 📝 `.github/actions/spelling/expect/expect.txt` (+87 -608) 📝 `.github/actions/spelling/expect/web.txt` (+0 -2) 📝 `.github/actions/spelling/line_forbidden.patterns` (+28 -2) 📝 `.github/actions/spelling/patterns/patterns.txt` (+56 -1) 📝 `.github/actions/spelling/reject.txt` (+4 -23) 📝 `.github/workflows/spelling2.yml` (+96 -8) 📝 `build/pgo/Terminal.PGO.props` (+4 -4) 📝 `doc/ConsoleHostSettings.md` (+1 -1) 📝 `doc/specs/#492 - Default Terminal/spec.md` (+1 -1) 📝 `doc/specs/#4993 - Keyboard Selection/Keyboard-Selection.md` (+1 -1) 📝 `doc/specs/#754 - Cascading Default Settings.md` (+4 -4) 📝 `doc/specs/#885 - Terminal Settings Model/#885 - Terminal Settings Model.md` (+2 -2) 📝 `scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj` (+1 -1) _...and 14 more files_ </details> ### 📄 Description Upgrades check-spelling to v0.0.21 The command to apply changes should now work on Windows (it requires Perl, but I believe that's more or less present most of the time, and it should walk you through the rest of the required tools). There are a bunch of new features, the most important here are probably being able to update the metadata from Windows. (If it doesn't work, please @ me). Also, candidate.patterns will automatically suggest patterns. You can see them in patterns.txt, e.g.: ``` # Automatically suggested patterns # hit-count: 3831 file-count: 582 # IServiceProvider \bI(?=(?:[A-Z][a-z]{2,})+\b) ``` The metadata bits (the hit count/file count) don't have to be retained (I hope they'll be useful in deciding whether/or not to add a pattern, i.e. "how applicable is it?"), the comment hinting at what the pattern does is probably worth retaining. We've been using more or less this version for a while internally (including talk-to-bot, and, I do have a pattern that could be used to let people use that in forks, but, I'm going to skip that for now). This weekend, I did some cleanup for `act` (to run check-spelling locally), and some minor polish. You can see the runs I made in https://github.com/check-spelling/terminal/actions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30094
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?