starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14456] [MERGED] Fix a couple issues with experimental.useBackgroundImageForWindow #30096

New Issue
Open
opened 2026-01-31 09:38:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14456
Author: @zadjii-msft
Created: 11/28/2022
Status: ✅ Merged
Merged: 11/29/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/14260-bgImageForWindow

📝 Commits (4)

  • fdb6752 This is one of the bugs I found, the residual image after disabling one
  • 14e270d the other part
  • 7b952cd Migrate spelling-0.0.21 changes from main
  • fe22354 Merge remote-tracking branch 'origin/main' into dev/migrie/b/14260-bgImageForWindow

📊 Changes

1 file changed (+21 additions, -14 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+21 -14)

📄 Description

This fixes two issues with experimental.useBackgroundImageForWindow I discovered while looking at #14260

  • It looks like the opacity of the whole-window BG image wouldn't hot reload if the path didn't.

  • set useBGForWindow:true, focus a pane with an image, then set it to useBGForWindow:false, and observe a pane with <100 opacity. You'll be able to see the BG image left behind!

These are pretty easy to miss, so I can see how it happened.

I don't think this technically closes that thread, though. Ultimately, I think OP's settings were just wrong (and possible didn't hot-reload). There's another, trickier bit I'm discussing in that thread, that might deserve its own separate follow-up for discussion.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14456 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 11/28/2022 **Status:** ✅ Merged **Merged:** 11/29/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/14260-bgImageForWindow` --- ### 📝 Commits (4) - [`fdb6752`](https://github.com/microsoft/terminal/commit/fdb6752daccd87dc6862bcc8ca4b86d23471c8f3) This is one of the bugs I found, the residual image after disabling one - [`14e270d`](https://github.com/microsoft/terminal/commit/14e270d57e517b8b73e4dc64afd750b17fcfd438) the other part - [`7b952cd`](https://github.com/microsoft/terminal/commit/7b952cdfb932257bcb8caff09310cd6b9e7ed3e8) Migrate spelling-0.0.21 changes from main - [`fe22354`](https://github.com/microsoft/terminal/commit/fe22354856621fa567e8fb9251ee212932f070e9) Merge remote-tracking branch 'origin/main' into dev/migrie/b/14260-bgImageForWindow ### 📊 Changes **1 file changed** (+21 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+21 -14) </details> ### 📄 Description This fixes two issues with `experimental.useBackgroundImageForWindow` I discovered while looking at #14260 * It looks like the opacity of the whole-window BG image wouldn't hot reload if the path didn't. * > set useBGForWindow:true, focus a pane with an image, then set it to useBGForWindow:false, and observe a pane with <100 opacity. You'll be able to see the BG image left behind! These are pretty easy to miss, so I can see how it happened. I don't think this _technically_ closes that thread, though. Ultimately, I think OP's settings were just wrong (and possible didn't hot-reload). There's another, trickier bit I'm discussing in that thread, that might deserve its own separate follow-up for discussion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30096
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?