starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14458] [MERGED] Clean up til::point/size/rect member usage #30098

New Issue
Open
opened 2026-01-31 09:38:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14458
Author: @lhecker
Created: 11/29/2022
Status: ✅ Merged
Merged: 12/1/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/4015-followup

📝 Commits (4)

  • bf0ef35 Clean up til::point/size/rect member usage
  • 03a1a63 Fix tests
  • d2549bd Fix build
  • d0b8d79 Merge remote-tracking branch 'origin/main' into dev/lhecker/4015-followup

📊 Changes

112 files changed (+2430 additions, -2493 deletions)

View changed files

📝 src/buffer/out/LineRendition.hpp (+3 -3)
📝 src/buffer/out/cursor.cpp (+6 -6)
📝 src/buffer/out/search.cpp (+4 -4)
📝 src/buffer/out/textBuffer.cpp (+91 -91)
📝 src/buffer/out/textBufferCellIterator.cpp (+14 -14)
📝 src/buffer/out/ut_textbuffer/ReflowTests.cpp (+1 -1)
📝 src/cascadia/PublicTerminalCore/HwndTerminal.cpp (+8 -8)
📝 src/cascadia/TerminalAzBridge/main.cpp (+4 -4)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+10 -10)
📝 src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp (+1 -1)
📝 src/cascadia/TerminalControl/TermControl.cpp (+3 -3)
📝 src/cascadia/TerminalCore/Terminal.cpp (+30 -30)
📝 src/cascadia/TerminalCore/Terminal.hpp (+1 -1)
📝 src/cascadia/TerminalCore/TerminalApi.cpp (+5 -5)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+18 -18)
📝 src/cascadia/TerminalCore/terminalrenderdata.cpp (+7 -7)
📝 src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp (+1 -1)
📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+23 -23)
📝 src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp (+4 -4)
📝 src/cascadia/UnitTests_TerminalCore/ScrollTest.cpp (+2 -2)

...and 80 more files

📄 Description

This is a follow-up of #13025 to make the members of til::point/size/rect
uniform and consistent without the use of unions. The only file that has
any changes is src/host/getset.cpp where an if condition was simplified.

Validation Steps Performed

  • Host unit tests ✅
  • Host feature tests ✅
  • ControlCore feature tests ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14458 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 11/29/2022 **Status:** ✅ Merged **Merged:** 12/1/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/4015-followup` --- ### 📝 Commits (4) - [`bf0ef35`](https://github.com/microsoft/terminal/commit/bf0ef35d8df95b0406d5b1ca5e65003ed328c894) Clean up til::point/size/rect member usage - [`03a1a63`](https://github.com/microsoft/terminal/commit/03a1a637514fbbd23e7b7dcbe7c166f59c415cac) Fix tests - [`d2549bd`](https://github.com/microsoft/terminal/commit/d2549bd698eb59cadcfc0ab3ee5886f955fccc6f) Fix build - [`d0b8d79`](https://github.com/microsoft/terminal/commit/d0b8d798df22086ada4be37a24c687d0f2ee480d) Merge remote-tracking branch 'origin/main' into dev/lhecker/4015-followup ### 📊 Changes **112 files changed** (+2430 additions, -2493 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/LineRendition.hpp` (+3 -3) 📝 `src/buffer/out/cursor.cpp` (+6 -6) 📝 `src/buffer/out/search.cpp` (+4 -4) 📝 `src/buffer/out/textBuffer.cpp` (+91 -91) 📝 `src/buffer/out/textBufferCellIterator.cpp` (+14 -14) 📝 `src/buffer/out/ut_textbuffer/ReflowTests.cpp` (+1 -1) 📝 `src/cascadia/PublicTerminalCore/HwndTerminal.cpp` (+8 -8) 📝 `src/cascadia/TerminalAzBridge/main.cpp` (+4 -4) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+10 -10) 📝 `src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+3 -3) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+30 -30) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+1 -1) 📝 `src/cascadia/TerminalCore/TerminalApi.cpp` (+5 -5) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+18 -18) 📝 `src/cascadia/TerminalCore/terminalrenderdata.cpp` (+7 -7) 📝 `src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp` (+1 -1) 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+23 -23) 📝 `src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp` (+4 -4) 📝 `src/cascadia/UnitTests_TerminalCore/ScrollTest.cpp` (+2 -2) _...and 80 more files_ </details> ### 📄 Description This is a follow-up of #13025 to make the members of `til::point/size/rect` uniform and consistent without the use of `unions`. The only file that has any changes is `src/host/getset.cpp` where an if condition was simplified. ## Validation Steps Performed * Host unit tests ✅ * Host feature tests ✅ * ControlCore feature tests ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?