[PR #14468] [MERGED] Merge the DotNet_###Test "platforms" back into the right place #30106

Open
opened 2026-01-31 09:38:40 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14468
Author: @DHowett
Created: 11/30/2022
Status: ✅ Merged
Merged: 11/30/2022
Merged by: @undefined

Base: main ← Head: dev/duhowett/no-more-testnetcore-configs


📝 Commits (3)

  • e68e129 Merge the DotNet_###Test "platforms" back into the right place
  • cf767b5 It looks like package restores need to be platformed!
  • 5c08195 okay but do it right this time

📊 Changes

3 files changed (+23 additions, -733 deletions)

View changed files

📝 OpenConsole.sln (+18 -732)
📝 build/pipelines/templates/restore-nuget-steps.yml (+4 -0)
📝 src/cascadia/WpfTerminalTestNetCore/WpfTerminalTestNetCore.csproj (+1 -1)

📄 Description

I originally added these platforms to prevent the .NET components from
building when you built the entire solution, and to prevent them from
building in CI.

It turns out that managing an extra thousand project-platform-config
triples is an absolute pain, and that we should have been building
these things in CI the entire time. So.

This should make life a lot easier.

As a bonus, this PR enables the WPF test harness to build for ARM64.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14468 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 11/30/2022 **Status:** ✅ Merged **Merged:** 11/30/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/no-more-testnetcore-configs` --- ### 📝 Commits (3) - [`e68e129`](https://github.com/microsoft/terminal/commit/e68e129644995f882b5c73e3751306beb2b3f046) Merge the DotNet_###Test "platforms" back into the right place - [`cf767b5`](https://github.com/microsoft/terminal/commit/cf767b50f56d509b8e0c456afbf1d80b9e2145d4) It looks like package restores need to be platformed! - [`5c08195`](https://github.com/microsoft/terminal/commit/5c08195da44db8d039085c7d924eb85bab683660) okay but do it right this time ### 📊 Changes **3 files changed** (+23 additions, -733 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+18 -732) 📝 `build/pipelines/templates/restore-nuget-steps.yml` (+4 -0) 📝 `src/cascadia/WpfTerminalTestNetCore/WpfTerminalTestNetCore.csproj` (+1 -1) </details> ### 📄 Description I originally added these platforms to prevent the .NET components from building when you built the entire solution, and to prevent them from building in CI. It turns out that managing an extra thousand project-platform-config triples is an absolute pain, **and** that we should have been building these things in CI the entire time. So. This should make life _a lot_ easier. As a bonus, this PR enables the WPF test harness to build for ARM64. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:40 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30106