[PR #14486] [MERGED] Make the Pane inactive border respect the theme.window.applicationTheme #30117

Open
opened 2026-01-31 09:38:44 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14486
Author: @zadjii-msft
Created: 12/2/2022
Status: ✅ Merged
Merged: 12/9/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/3917-finally


📝 Commits (2)

📊 Changes

4 files changed (+29 additions, -16 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.xaml (+2 -2)
📝 src/cascadia/TerminalApp/Pane.cpp (+9 -12)
📝 src/cascadia/TerminalApp/Pane.h (+2 -2)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+16 -0)

📄 Description

We couldn't do this before, because App::Current().Resources().Lookup() would always return the OS theme version of a resource. That thread has lengthy details on why.

FORTUNATELY FOR US, this isn't the first time we've dealt with this. We've come up with a workaround in the past, and we can just use it again here.

Closes #3917

This will also make #3061 easy 😉


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14486 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/2/2022 **Status:** ✅ Merged **Merged:** 12/9/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/3917-finally` --- ### 📝 Commits (2) - [`b1017b9`](https://github.com/microsoft/terminal/commit/b1017b95e6f0b8652baa93a982c0d32252804b3b) fixes #3917 - [`4f2a3a7`](https://github.com/microsoft/terminal/commit/4f2a3a7fbce9993d79f680f0c2940aeaeb7beabd) Update src/cascadia/TerminalApp/TerminalPage.cpp ### 📊 Changes **4 files changed** (+29 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.xaml` (+2 -2) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+9 -12) 📝 `src/cascadia/TerminalApp/Pane.h` (+2 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+16 -0) </details> ### 📄 Description We couldn't do this before, because `App::Current().Resources().Lookup()` would always return the OS theme version of a resource. That thread has lengthy details on why. FORTUNATELY FOR US, this isn't the first time we've dealt with this. We've come up with a workaround in the past, and we can just use it again here. Closes #3917 This will also make #3061 easy 😉 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:44 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30117