[PR #14518] [MERGED] Fix setting launch position in the Settings UI not working #30127

Open
opened 2026-01-31 09:38:48 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14518
Author: @PankajBhojwani
Created: 12/8/2022
Status: ✅ Merged
Merged: 12/9/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/fix_launch_params


📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp (+2 -2)

📄 Description

Summary of the Pull Request

This change should have been a part of #14190 but was missed.

PR Checklist

Validation Steps Performed

Setting launch position in the settings UI works now


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14518 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 12/8/2022 **Status:** ✅ Merged **Merged:** 12/9/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/fix_launch_params` --- ### 📝 Commits (1) - [`0161bb4`](https://github.com/microsoft/terminal/commit/0161bb43da5c55a5127be62014212ef84853584d) these need to be 32 too ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp` (+2 -2) </details> ### 📄 Description ## Summary of the Pull Request This change should have been a part of #14190 but was missed. ## PR Checklist * [x] Closes #14469 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Setting launch position in the settings UI works now --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:48 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30127