[PR #14520] [MERGED] Remove our dependency on Microsoft.Toolkit.Win32.UI.XamlApplication #30134

Open
opened 2026-01-31 09:38:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14520
Author: @DHowett
Created: 12/9/2022
Status: Merged
Merged: 12/12/2022
Merged by: @undefined

Base: mainHead: dev/duhowett/hax/no-more-xamlhost


📝 Commits (4)

📊 Changes

19 files changed (+148 additions, -63 deletions)

View changed files

📝 dep/nuget/packages.config (+0 -1)
📝 scratch/ScratchIslandApp/SampleApp/App.cpp (+40 -9)
📝 scratch/ScratchIslandApp/SampleApp/App.h (+10 -0)
📝 scratch/ScratchIslandApp/SampleApp/App.idl (+3 -1)
📝 scratch/ScratchIslandApp/SampleApp/App.xaml (+11 -12)
📝 scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj (+10 -1)
📝 scratch/ScratchIslandApp/SampleApp/dll/SampleApp.vcxproj (+0 -1)
📝 scratch/ScratchIslandApp/SampleApp/pch.h (+0 -1)
📝 src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj (+0 -1)
📝 src/cascadia/TerminalApp/App.cpp (+40 -9)
📝 src/cascadia/TerminalApp/App.h (+12 -0)
📝 src/cascadia/TerminalApp/App.idl (+3 -1)
📝 src/cascadia/TerminalApp/App.xaml (+11 -12)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj (+8 -1)
📝 src/cascadia/TerminalApp/dll/TerminalApp.vcxproj (+0 -1)
📝 src/cascadia/TerminalApp/pch.h (+0 -1)
📝 src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj (+0 -1)
📝 src/common.nugetversions.props (+0 -3)
📝 src/common.nugetversions.targets (+0 -7)

📄 Description

We originally needed this library (or a separate DLL in our own project)
to handle hooking up the XAML resource loader to the providers that our
application needed. It was introduced in its nascent form in 2019, in a
PR titled "Make XAML files work."

It appears we no longer need it, and the provider hookup is being
handled by our AppT2 base class override. I've tested this in Windows
10 Vb running unpackaged, and it seems to work totally fine. Crazy.

Removing this dependency saves us a couple hundred kilobytes on disk and
removes one consumer of the App CRT from our package.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14520 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 12/9/2022 **Status:** ✅ Merged **Merged:** 12/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/hax/no-more-xamlhost` --- ### 📝 Commits (4) - [`d994fd8`](https://github.com/microsoft/terminal/commit/d994fd8ac44235da19bdd8d7751b22c7fbfc235b) HAX: Remove our Toolkit dependency - [`0ebae27`](https://github.com/microsoft/terminal/commit/0ebae275a059c779f52ce31f83bf0d2df0dc480a) Get the toolkit project too - [`3fb69d3`](https://github.com/microsoft/terminal/commit/3fb69d38b4cbb5a41e1a82cefb67208182b98ded) format code - [`35786d0`](https://github.com/microsoft/terminal/commit/35786d048b02c79622b5030d46d43e5f520c398a) Also these includes... ### 📊 Changes **19 files changed** (+148 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `dep/nuget/packages.config` (+0 -1) 📝 `scratch/ScratchIslandApp/SampleApp/App.cpp` (+40 -9) 📝 `scratch/ScratchIslandApp/SampleApp/App.h` (+10 -0) 📝 `scratch/ScratchIslandApp/SampleApp/App.idl` (+3 -1) 📝 `scratch/ScratchIslandApp/SampleApp/App.xaml` (+11 -12) 📝 `scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj` (+10 -1) 📝 `scratch/ScratchIslandApp/SampleApp/dll/SampleApp.vcxproj` (+0 -1) 📝 `scratch/ScratchIslandApp/SampleApp/pch.h` (+0 -1) 📝 `src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj` (+0 -1) 📝 `src/cascadia/TerminalApp/App.cpp` (+40 -9) 📝 `src/cascadia/TerminalApp/App.h` (+12 -0) 📝 `src/cascadia/TerminalApp/App.idl` (+3 -1) 📝 `src/cascadia/TerminalApp/App.xaml` (+11 -12) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj` (+8 -1) 📝 `src/cascadia/TerminalApp/dll/TerminalApp.vcxproj` (+0 -1) 📝 `src/cascadia/TerminalApp/pch.h` (+0 -1) 📝 `src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj` (+0 -1) 📝 `src/common.nugetversions.props` (+0 -3) 📝 `src/common.nugetversions.targets` (+0 -7) </details> ### 📄 Description We originally needed this library (or a separate DLL in our own project) to handle hooking up the XAML resource loader to the providers that our application needed. It was introduced in its nascent form in 2019, in a PR titled "Make XAML files work." It appears we no longer need it, and the provider hookup is being handled by our `AppT2` base class override. I've tested this in Windows 10 Vb running unpackaged, and it seems to work totally fine. Crazy. Removing this dependency saves us a couple hundred kilobytes on disk and removes one consumer of the App CRT from our package. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30134