[PR #14534] [MERGED] Don't crash when turning on Voice Access #30135

Open
opened 2026-01-31 09:38:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14534
Author: @zadjii-msft
Created: 12/12/2022
Status: Merged
Merged: 12/12/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/14504-voice-access-crash


📝 Commits (1)

📊 Changes

1 file changed (+12 additions, -6 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+12 -6)

📄 Description

I should have checked the wparam.

Regressed in #14064.

Tested manually. No more crashy.

Closes #14504


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14534 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/12/2022 **Status:** ✅ Merged **Merged:** 12/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/14504-voice-access-crash` --- ### 📝 Commits (1) - [`6672f6b`](https://github.com/microsoft/terminal/commit/6672f6bc5100986c8905b70507a28568d22bb678) this was silly ### 📊 Changes **1 file changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+12 -6) </details> ### 📄 Description I should have checked the `wparam`. Regressed in #14064. Tested manually. No more crashy. Closes #14504 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30135