[PR #14536] [MERGED] Use a dark titlebar when we've requested dark theme #30138

Open
opened 2026-01-31 09:38:51 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14536
Author: @zadjii-msft
Created: 12/12/2022
Status: Merged
Merged: 1/19/2023
Merged by: @undefined

Base: mainHead: dev/migrie/b/dark-titlebars-for-dark-theme


📝 Commits (10+)

  • 8c3c8fe Revert "Remove the useMica key (#13872)"
  • 0a3a537 Clip the drag rect to the right side of the window. I don't think this really matters.
  • 2fcc420 add support for transparent titlebars back, for testing.
  • 337c5e9 hey this works - let's clean it up and figure out what is/n't important
  • c77173b Add better support in the Theme objects themselves for transparency
  • df6d4cd way easier
  • 2895a34 notes, mostly
  • 3d5d88a inintial buggy fix for syncing OS themes
  • 5f54750 fixed control preview bug
  • 43cc9fa Code cleanup

📊 Changes

13 files changed (+66 additions, -45 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp (+1 -2)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj (+0 -1)
src/cascadia/TerminalSettingsModel/SettingsUtils.h (+0 -6)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+1 -12)
📝 src/cascadia/TerminalSettingsModel/Theme.cpp (+10 -0)
📝 src/cascadia/TerminalSettingsModel/Theme.h (+2 -0)
📝 src/cascadia/TerminalSettingsModel/Theme.idl (+1 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+20 -0)
📝 src/cascadia/WindowsTerminal/BaseWindow.h (+2 -2)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+26 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+3 -0)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+0 -21)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.h (+0 -1)

📄 Description

This applies to "showTabsInTitlebar": false,. We literally never set that for the IslandWindow before, only ever the NCIW.

Closes #11589

update-titlebar-for-theme

For a dramatic example - here's the IW with mica enabled, in dark mode:

image

Theme json:

        {
            "name": "chonk",
            "tab":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
                "showCloseButton": "never"
            },
            "tabRow":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
            },
            "window":
            {
                "applicationTheme": "dark",
                "useMica": true
            }
        },

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14536 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/12/2022 **Status:** ✅ Merged **Merged:** 1/19/2023 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/dark-titlebars-for-dark-theme` --- ### 📝 Commits (10+) - [`8c3c8fe`](https://github.com/microsoft/terminal/commit/8c3c8fef8907293810390cea6d1c4489bef9b5e3) Revert "Remove the `useMica` key (#13872)" - [`0a3a537`](https://github.com/microsoft/terminal/commit/0a3a537c363dd587600f7caf47c440ba83604745) Clip the drag rect to the right side of the window. I don't think this really matters. - [`2fcc420`](https://github.com/microsoft/terminal/commit/2fcc420d84bd937f627118130cba8180d7ec4883) add support for transparent titlebars back, for testing. - [`337c5e9`](https://github.com/microsoft/terminal/commit/337c5e9a60911216b42f47b160e0fdcf0455493c) hey this works - let's clean it up and figure out what is/n't important - [`c77173b`](https://github.com/microsoft/terminal/commit/c77173ba7b0ddcc00b963633dd968510882ee3b5) Add better support in the Theme objects themselves for transparency - [`df6d4cd`](https://github.com/microsoft/terminal/commit/df6d4cd0aed277c13a09bd234517f521ba72e544) way easier - [`2895a34`](https://github.com/microsoft/terminal/commit/2895a34085f8878766458da6c53f648c29fc8924) notes, mostly - [`3d5d88a`](https://github.com/microsoft/terminal/commit/3d5d88a41def9d7e17fabfe44b20992f1419f5c8) inintial buggy fix for syncing OS themes - [`5f54750`](https://github.com/microsoft/terminal/commit/5f547501b56d112447d87f121bb28b8f664162f1) fixed control preview bug - [`43cc9fa`](https://github.com/microsoft/terminal/commit/43cc9fadd602028f47f850de62be8bf1c48fc172) Code cleanup ### 📊 Changes **13 files changed** (+66 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp` (+1 -2) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj` (+0 -1) ➖ `src/cascadia/TerminalSettingsModel/SettingsUtils.h` (+0 -6) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+1 -12) 📝 `src/cascadia/TerminalSettingsModel/Theme.cpp` (+10 -0) 📝 `src/cascadia/TerminalSettingsModel/Theme.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/Theme.idl` (+1 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+20 -0) 📝 `src/cascadia/WindowsTerminal/BaseWindow.h` (+2 -2) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+26 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+3 -0) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+0 -21) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.h` (+0 -1) </details> ### 📄 Description This applies to `"showTabsInTitlebar": false,`. We literally never set that for the `IslandWindow` before, only ever the NCIW. Closes #11589 ![update-titlebar-for-theme](https://user-images.githubusercontent.com/18356694/207109370-a63a8b19-4c42-4b1f-8d39-8c3abdf1b403.gif) For a dramatic example - here's the IW with mica enabled, in dark mode: ![image](https://user-images.githubusercontent.com/18356694/207109465-a6165637-31a5-45a4-bff0-51ac79404cd6.png) Theme json: ```json { "name": "chonk", "tab": { "background": "#00000000", "unfocusedBackground": "#00000000", "showCloseButton": "never" }, "tabRow": { "background": "#00000000", "unfocusedBackground": "#00000000", }, "window": { "applicationTheme": "dark", "useMica": true } }, ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:51 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30138