starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14541] [MERGED] Introduce PseudoConsoleWindow a11y provider #30147

New Issue
Open
opened 2026-01-31 09:38:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:38:55 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14541
Author: @carlos-zamora
Created: 12/13/2022
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @undefined

Base: main ← Head: dev/cazamor/a11y/pseudo-console-window

📝 Commits (5)

📊 Changes

7 files changed (+145 additions, -4 deletions)

View changed files

📝 src/interactivity/base/InteractivityFactory.cpp (+13 -1)
📝 src/interactivity/base/InteractivityFactory.hpp (+4 -0)
➕ src/interactivity/base/PseudoConsoleWindowAccessibilityProvider.cpp (+79 -0)
➕ src/interactivity/base/PseudoConsoleWindowAccessibilityProvider.hpp (+34 -0)
📝 src/interactivity/base/lib/InteractivityBase.vcxproj (+3 -1)
📝 src/interactivity/base/lib/InteractivityBase.vcxproj.filters (+9 -0)
📝 src/interactivity/base/sources.inc (+3 -2)

📄 Description

In order to modify the accessibility information for the PseudoConsoleWindow, it needs to have a UIA provider registered. This PR introduces PseudoConsoleWindowAccessibilityProvider and registers it as a UIA provider appropriately. The registration process is based on that of the WindowUiaProvider for ConHost.

Closes #14385

Validation Steps Performed

Run Accessibility Insights FastPass on the window. The PseudoConsoleWindow no longer is tagged as missing a name.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14541 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 12/13/2022 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/a11y/pseudo-console-window` --- ### 📝 Commits (5) - [`25bc6fa`](https://github.com/microsoft/terminal/commit/25bc6fad30cdb8e9be6fdc3c6bfe28e15666de8e) Introduce PseudoConsoleWindow a11y provider - [`767cabf`](https://github.com/microsoft/terminal/commit/767cabfa5638f43a8aa15cadcbf5209338e6f25c) reduce diff size - [`8c2108c`](https://github.com/microsoft/terminal/commit/8c2108c9a8f2be25a0bbf6094c398887d883924f) address Dustin's comments - [`afc797a`](https://github.com/microsoft/terminal/commit/afc797ac28e4f1e23463c3b0c1fb97863a3d7026) take a break - [`0fc13c4`](https://github.com/microsoft/terminal/commit/0fc13c4347b4ccb0a27ab01c3581ccbe86ad4e37) address Dustin's feedback ### 📊 Changes **7 files changed** (+145 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/interactivity/base/InteractivityFactory.cpp` (+13 -1) 📝 `src/interactivity/base/InteractivityFactory.hpp` (+4 -0) ➕ `src/interactivity/base/PseudoConsoleWindowAccessibilityProvider.cpp` (+79 -0) ➕ `src/interactivity/base/PseudoConsoleWindowAccessibilityProvider.hpp` (+34 -0) 📝 `src/interactivity/base/lib/InteractivityBase.vcxproj` (+3 -1) 📝 `src/interactivity/base/lib/InteractivityBase.vcxproj.filters` (+9 -0) 📝 `src/interactivity/base/sources.inc` (+3 -2) </details> ### 📄 Description In order to modify the accessibility information for the PseudoConsoleWindow, it needs to have a UIA provider registered. This PR introduces `PseudoConsoleWindowAccessibilityProvider` and registers it as a UIA provider appropriately. The registration process is based on that of the `WindowUiaProvider` for ConHost. Closes #14385 ## Validation Steps Performed Run Accessibility Insights FastPass on the window. The PseudoConsoleWindow no longer is tagged as missing a name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:38:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30147
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?