[PR #14572] [MERGED] Update Profile and Appearance VMs to use CSVM; remove nav state #30166

Open
opened 2026-01-31 09:39:04 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14572
Author: @PankajBhojwani
Created: 12/16/2022
Status: Merged
Merged: 1/18/2023
Merged by: @DHowett

Base: mainHead: dev/pabhoj/use_csvm_in_profiles


📝 Commits (9)

  • 52eaecb seems to work
  • 4c546c8 progress towards removing nav state
  • f4f09c0 remove navigation state
  • e5ef839 helper
  • 6593895 initialize profileVMs after schemesPageVM
  • 0e20851 conflict
  • e620652 use page VM's list of schemes, bring back focusdeletebutton
  • 1071425 use list instead of page, move to VM
  • f420847 fix reset button

📊 Changes

18 files changed (+96 additions, -156 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+29 -29)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+4 -7)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+6 -5)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+4 -4)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+20 -21)
📝 src/cascadia/TerminalSettingsEditor/MainPage.h (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+0 -7)
📝 src/cascadia/TerminalSettingsEditor/ProfileViewModel.cpp (+13 -12)
📝 src/cascadia/TerminalSettingsEditor/ProfileViewModel.h (+2 -3)
📝 src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl (+4 -0)
src/cascadia/TerminalSettingsEditor/Profiles.h (+0 -38)
src/cascadia/TerminalSettingsEditor/Profiles.idl (+0 -14)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Advanced.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Advanced.idl (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Appearance.cpp (+2 -3)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Appearance.idl (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Base.cpp (+5 -6)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Base.idl (+1 -1)

📄 Description

ColorScheme MVVM was implemented in #13179. This PR updates the
ProfileViewModel/AppearanceViewModels to use color scheme view models
instead of the raw settings model objects.

  • Updates ProfileViewModel/AppearanceViewModel to use
    ColorSchemesPageViewModel/ColorSchemeViewModel implemented in #13179
  • Removes ProfilePageNavigationState

Validation Steps Performed

Settings UI still works (we probably want to bug bash this at some
point though as with all SUI changes)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14572 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 12/16/2022 **Status:** ✅ Merged **Merged:** 1/18/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/pabhoj/use_csvm_in_profiles` --- ### 📝 Commits (9) - [`52eaecb`](https://github.com/microsoft/terminal/commit/52eaecb6054549071456c71704c815d45c63275d) seems to work - [`4c546c8`](https://github.com/microsoft/terminal/commit/4c546c88e3d78653a1e8c656a3c9def7a20242a8) progress towards removing nav state - [`f4f09c0`](https://github.com/microsoft/terminal/commit/f4f09c008c4a3970658faba7e94c209925cb532b) remove navigation state - [`e5ef839`](https://github.com/microsoft/terminal/commit/e5ef83920f76ebb61f7216840421ac8f2f7b86cf) helper - [`6593895`](https://github.com/microsoft/terminal/commit/6593895b34a25dec9f411eea3ba5b1d000c0887a) initialize profileVMs after schemesPageVM - [`0e20851`](https://github.com/microsoft/terminal/commit/0e208511551aef348a01405676555000d7dce137) conflict - [`e620652`](https://github.com/microsoft/terminal/commit/e620652e98eb42b344a024dc863e1726f6b2253f) use page VM's list of schemes, bring back focusdeletebutton - [`1071425`](https://github.com/microsoft/terminal/commit/107142506a3e169a004b4152bdb1abb40c35bd06) use list instead of page, move to VM - [`f420847`](https://github.com/microsoft/terminal/commit/f420847bd743a029e3d86d1638baa549af03aa73) fix reset button ### 📊 Changes **18 files changed** (+96 additions, -156 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+29 -29) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+4 -7) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+6 -5) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+4 -4) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+20 -21) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.h` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+0 -7) 📝 `src/cascadia/TerminalSettingsEditor/ProfileViewModel.cpp` (+13 -12) 📝 `src/cascadia/TerminalSettingsEditor/ProfileViewModel.h` (+2 -3) 📝 `src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl` (+4 -0) ➖ `src/cascadia/TerminalSettingsEditor/Profiles.h` (+0 -38) ➖ `src/cascadia/TerminalSettingsEditor/Profiles.idl` (+0 -14) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Advanced.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Advanced.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Appearance.cpp` (+2 -3) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Appearance.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Base.cpp` (+5 -6) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Base.idl` (+1 -1) </details> ### 📄 Description ColorScheme MVVM was implemented in #13179. This PR updates the ProfileViewModel/AppearanceViewModels to use color scheme view models instead of the raw settings model objects. * [x] Updates ProfileViewModel/AppearanceViewModel to use ColorSchemesPageViewModel/ColorSchemeViewModel implemented in #13179 * [x] Removes ProfilePageNavigationState ## Validation Steps Performed Settings UI still works (we _probably_ want to bug bash this at some point though as with all SUI changes) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30166