starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14637] [MERGED] Launch elevated instances via shell:AppFolder #30174

New Issue
Open
opened 2026-01-31 09:39:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14637
Author: @jboelter
Created: 1/5/2023
Status: ✅ Merged
Merged: 1/19/2023
Merged by: @undefined

Base: main ← Head: bug/14501-elevate-dllpath

📝 Commits (9)

  • 62017c0 Launch elevated instances via shell:AppFolder
  • 145dd52 length() -> size()
  • 039307f make spell check happy
  • 9c794e6 make argc const to satisfy audit mode build
  • f69a69e add wargv to recognized words
  • 74c4b0c Minimized scope of changes and use WIL
  • 1aa94bb fix spelling
  • 405e89e simplification to only change elevate-shim
  • f94b4e9 make audit mode happy

📊 Changes

1 file changed (+64 additions, -9 deletions)

View changed files

📝 src/cascadia/ElevateShim/elevate-shim.cpp (+64 -9)

📄 Description

This uses shell:AppsFolder to launch elevated instances of the app via
ShellExecuteEx and runas in elevate-shim.exe. The app to launch is
discovered via the GetCurrentApplicationUserModelId API.

e.g. shell:AppsFolder\WindowsTerminalDev_8wekyb3d8bbwe!App

This will fallback to launching WindowsTerminal.exe if it fails to
discover the app user model id to launch.

This also fixes a bug in elevate-shim where the first argument of
WinMain was lost (e.g. new-tab).

Curiously, AppLogic::RunAsUwp() is never called and
AppLogic::IsUwp() is always false when running debug builds locally
(e.g. WindowsTerminalDev). It's not clear if this is an artifact of
development packages or something else.

Validation Steps Performed

Various manual debug/execution scenarios.

Verified the fallback path by running the unbundled app by extracting
the CascadiaPackage_0.0.1.0_x64.msix from the 'drop' build artifact.

Fixes #14501

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14637 **Author:** [@jboelter](https://github.com/jboelter) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 1/19/2023 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `bug/14501-elevate-dllpath` --- ### 📝 Commits (9) - [`62017c0`](https://github.com/microsoft/terminal/commit/62017c0f56ffdc4a632642154354de78d68844ee) Launch elevated instances via shell:AppFolder - [`145dd52`](https://github.com/microsoft/terminal/commit/145dd52f648890703b3b069927201103da008b6c) length() -> size() - [`039307f`](https://github.com/microsoft/terminal/commit/039307f6cca8beaba2f096727acde3c29219dca9) make spell check happy - [`9c794e6`](https://github.com/microsoft/terminal/commit/9c794e6fc4798e37bc4569898d3de050690f3eca) make argc const to satisfy audit mode build - [`f69a69e`](https://github.com/microsoft/terminal/commit/f69a69e3d70d855eef05f8fac744c093c8c1c685) add wargv to recognized words - [`74c4b0c`](https://github.com/microsoft/terminal/commit/74c4b0c50792845158dde09008b25924b641a35c) Minimized scope of changes and use WIL - [`1aa94bb`](https://github.com/microsoft/terminal/commit/1aa94bb3a5e3de36e344d14ae6eff313f5c15479) fix spelling - [`405e89e`](https://github.com/microsoft/terminal/commit/405e89e057922867d753548938b7a5bb81eccd8c) simplification to only change elevate-shim - [`f94b4e9`](https://github.com/microsoft/terminal/commit/f94b4e9d2a70117e61bf81eb4796f29cb8199a18) make audit mode happy ### 📊 Changes **1 file changed** (+64 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/ElevateShim/elevate-shim.cpp` (+64 -9) </details> ### 📄 Description This uses `shell:AppsFolder` to launch elevated instances of the app via `ShellExecuteEx` and `runas` in elevate-shim.exe. The app to launch is discovered via the `GetCurrentApplicationUserModelId` API. e.g. `shell:AppsFolder\WindowsTerminalDev_8wekyb3d8bbwe!App` This will fallback to launching `WindowsTerminal.exe` if it fails to discover the app user model id to launch. This also fixes a bug in elevate-shim where the first argument of WinMain was lost (e.g. `new-tab`). Curiously, `AppLogic::RunAsUwp()` is never called and `AppLogic::IsUwp()` is always false when running debug builds locally (e.g. WindowsTerminalDev). It's not clear if this is an artifact of development packages or something else. ## Validation Steps Performed Various manual debug/execution scenarios. Verified the fallback path by running the unbundled app by extracting the `CascadiaPackage_0.0.1.0_x64.msix` from the 'drop' build artifact. Fixes #14501 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30174
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?