[PR #14643] [MERGED] Make sure focused tab text color accounts for alpha #30180

Closed
opened 2026-01-31 09:39:09 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14643
Author: @zadjii-msft
Created: 1/6/2023
Status: Merged
Merged: 1/16/2023
Merged by: @undefined

Base: mainHead: dev/migrie/b/14561-invisible-tab-text-color


📝 Commits (1)

  • ff8c50a Make sure focused tab text accounts for alpha

📊 Changes

1 file changed (+20 additions, -10 deletions)

View changed files

📝 src/cascadia/TerminalApp/TabBase.cpp (+20 -10)

📄 Description

Basically what it says on the tin. For transparent tabs, we should layer on to the tab row to evaluate what the actual color of the tab will be. We did this for deselected tabs, but not for selected ones.

Gif below.

Closes #14561


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14643 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/6/2023 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/14561-invisible-tab-text-color` --- ### 📝 Commits (1) - [`ff8c50a`](https://github.com/microsoft/terminal/commit/ff8c50a220953308864386cf2d982c54423ccd5b) Make sure focused tab text accounts for alpha ### 📊 Changes **1 file changed** (+20 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TabBase.cpp` (+20 -10) </details> ### 📄 Description Basically what it says on the tin. For transparent tabs, we should layer on to the tab row to evaluate what the actual color of the tab will be. We did this for deselected tabs, but not for selected ones. Gif below. Closes #14561 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:09 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30180