starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14673] [MERGED] Ensure export and find tab context menu items work for unfocused tabs #30197

New Issue
Open
opened 2026-01-31 09:39:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14673
Author: @ianjoneill
Created: 1/13/2023
Status: ✅ Merged
Merged: 1/16/2023
Merged by: @undefined

Base: main ← Head: b-fix-export-and-find-tab-context-menu

📝 Commits (2)

  • b358f86 Ensure export and find tab context menu items work for unfocused tabs
  • 8310527 Update doc-string

📊 Changes

4 files changed (+15 additions, -11 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+4 -1)
📝 src/cascadia/TerminalApp/TabManagement.cpp (+5 -4)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+5 -5)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)

📄 Description

Summary of the Pull Request

Updates the tab event handling so that the "Export Text" and "Find" tab context menu items work when a tab isn't focused.

PR Checklist

  • Closes I need to get back to the original setup settings to change those (#13948)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Manually tested.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14673 **Author:** [@ianjoneill](https://github.com/ianjoneill) **Created:** 1/13/2023 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `b-fix-export-and-find-tab-context-menu` --- ### 📝 Commits (2) - [`b358f86`](https://github.com/microsoft/terminal/commit/b358f862a1f6c73bf9b2f39cad9b6713a7d2cdaa) Ensure export and find tab context menu items work for unfocused tabs - [`8310527`](https://github.com/microsoft/terminal/commit/8310527b8dab283f48e5a85814c895e0930b00cf) Update doc-string ### 📊 Changes **4 files changed** (+15 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+4 -1) 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+5 -4) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+5 -5) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request Updates the tab event handling so that the "Export Text" and "Find" tab context menu items work when a tab isn't focused. ## PR Checklist * [x] Closes #13948 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Manually tested. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30197
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?