starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14733] [MERGED] Generalize OpenConsoleProxy's HybridCRT logic #30232

New Issue
Open
opened 2026-01-31 09:39:28 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:28 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14733
Author: @DHowett
Created: 1/25/2023
Status: ✅ Merged
Merged: 1/27/2023
Merged by: @undefined

Base: main ← Head: dev/duhowett/hybrid-crt

📝 Commits (8)

  • aaff3d2 Try this again...
  • b9a9f84 Make hybrid CRT opt-out
  • c62121d Merge remote-tracking branch 'origin/main' into dev/duhowett/hybrid-crt
  • c86f5bc huh.
  • 4ecf2ce Migrate spelling-0.0.21 changes from main
  • 1029475 Merge remote-tracking branch 'origin/main' into dev/duhowett/hybrid-crt
  • d37f245 Remove vestigial comment
  • 9d1b695 flip the default sense of HybridCRT

📊 Changes

5 files changed (+46 additions, -38 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj (+1 -0)
📝 src/cascadia/PublicTerminalCore/PublicTerminalCore.vcxproj (+1 -1)
📝 src/common.build.post.props (+36 -0)
📝 src/cppwinrt.build.pre.props (+1 -0)
📝 src/host/proxy/Host.Proxy.vcxproj (+7 -37)

📄 Description

This pull request moves the Hybrid CRT logic out of the Host.Proxy
project and makes it available for all other projects in our solution.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14733 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 1/25/2023 **Status:** ✅ Merged **Merged:** 1/27/2023 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/hybrid-crt` --- ### 📝 Commits (8) - [`aaff3d2`](https://github.com/microsoft/terminal/commit/aaff3d28514fc7abffd14a7e9aef2c8e88e8ccb3) Try this again... - [`b9a9f84`](https://github.com/microsoft/terminal/commit/b9a9f842ac1ace521237db19e9a217fe192b8b68) Make hybrid CRT opt-out - [`c62121d`](https://github.com/microsoft/terminal/commit/c62121d898118974f72f4325a651afc734a5cc3e) Merge remote-tracking branch 'origin/main' into dev/duhowett/hybrid-crt - [`c86f5bc`](https://github.com/microsoft/terminal/commit/c86f5bcbba830e26569c2f9931448d48ec9489f6) huh. - [`4ecf2ce`](https://github.com/microsoft/terminal/commit/4ecf2ce4c9b6950f1e89003a5e1664cb14db848f) Migrate spelling-0.0.21 changes from main - [`1029475`](https://github.com/microsoft/terminal/commit/10294752a6849f5581cf21e924a6ffe88232c6b8) Merge remote-tracking branch 'origin/main' into dev/duhowett/hybrid-crt - [`d37f245`](https://github.com/microsoft/terminal/commit/d37f245b3229f15a899b0ce8b962d338e02b6a16) Remove vestigial comment - [`9d1b695`](https://github.com/microsoft/terminal/commit/9d1b6953e429780d68bf45e6b4957c63e71f62a6) flip the default sense of HybridCRT ### 📊 Changes **5 files changed** (+46 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj` (+1 -0) 📝 `src/cascadia/PublicTerminalCore/PublicTerminalCore.vcxproj` (+1 -1) 📝 `src/common.build.post.props` (+36 -0) 📝 `src/cppwinrt.build.pre.props` (+1 -0) 📝 `src/host/proxy/Host.Proxy.vcxproj` (+7 -37) </details> ### 📄 Description This pull request moves the Hybrid CRT logic out of the Host.Proxy project and makes it available for all other projects in our solution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30232
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?