[PR #14763] [MERGED] Replace gsl::byte/span with std #30243

Open
opened 2026-01-31 09:39:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14763
Author: @lhecker
Created: 1/30/2023
Status: Merged
Merged: 2/2/2023
Merged by: @carlos-zamora

Base: mainHead: dev/lhecker/gsl-span-byte


📝 Commits (3)

  • 12d306f Replace gsl::byte/span with std
  • 0ba9d7b Fix AuditMode failures
  • 0e79cc7 Simplify VTParameters::for_each

📊 Changes

97 files changed (+359 additions, -383 deletions)

View changed files

📝 src/buffer/out/OutputCellIterator.cpp (+9 -9)
📝 src/buffer/out/OutputCellIterator.hpp (+7 -7)
📝 src/buffer/out/OutputCellRect.cpp (+3 -3)
📝 src/buffer/out/OutputCellRect.hpp (+1 -1)
📝 src/cascadia/LocalTests_SettingsModel/ColorSchemeTests.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+4 -4)
📝 src/cascadia/TerminalSettingsModel/DynamicProfileUtils.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsModel/Profile.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsModel/VsDevShellGenerator.cpp (+1 -1)
📝 src/cascadia/UnitTests_TerminalCore/ScrollTest.cpp (+2 -2)
📝 src/common.build.pre.props (+1 -1)
📝 src/host/ApiRoutines.h (+24 -24)
📝 src/host/VtApiRoutines.cpp (+25 -25)
📝 src/host/VtApiRoutines.h (+24 -24)
📝 src/host/_output.cpp (+1 -1)
📝 src/host/alias.cpp (+12 -12)

...and 77 more files

📄 Description

This is a rather trivial changeset. Now that these two are present in the
std namespace there's no reason for us to continue using the gsl ones.
Additionally this ensures future compatibility with other 3rd party libraries.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14763 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 1/30/2023 **Status:** ✅ Merged **Merged:** 2/2/2023 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `main` ← **Head:** `dev/lhecker/gsl-span-byte` --- ### 📝 Commits (3) - [`12d306f`](https://github.com/microsoft/terminal/commit/12d306fdd7154f9a736673a765609805d37524cd) Replace gsl::byte/span with std - [`0ba9d7b`](https://github.com/microsoft/terminal/commit/0ba9d7b79fa0014f50d9d79b07bee62f18c2c52f) Fix AuditMode failures - [`0e79cc7`](https://github.com/microsoft/terminal/commit/0e79cc77d6913ede76ebefbdc7c847be5188df25) Simplify VTParameters::for_each ### 📊 Changes **97 files changed** (+359 additions, -383 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/OutputCellIterator.cpp` (+9 -9) 📝 `src/buffer/out/OutputCellIterator.hpp` (+7 -7) 📝 `src/buffer/out/OutputCellRect.cpp` (+3 -3) 📝 `src/buffer/out/OutputCellRect.hpp` (+1 -1) 📝 `src/cascadia/LocalTests_SettingsModel/ColorSchemeTests.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+4 -4) 📝 `src/cascadia/TerminalSettingsModel/DynamicProfileUtils.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/Profile.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/VsDevShellGenerator.cpp` (+1 -1) 📝 `src/cascadia/UnitTests_TerminalCore/ScrollTest.cpp` (+2 -2) 📝 `src/common.build.pre.props` (+1 -1) 📝 `src/host/ApiRoutines.h` (+24 -24) 📝 `src/host/VtApiRoutines.cpp` (+25 -25) 📝 `src/host/VtApiRoutines.h` (+24 -24) 📝 `src/host/_output.cpp` (+1 -1) 📝 `src/host/alias.cpp` (+12 -12) _...and 77 more files_ </details> ### 📄 Description This is a rather trivial changeset. Now that these two are present in the `std` namespace there's no reason for us to continue using the `gsl` ones. Additionally this ensures future compatibility with other 3rd party libraries. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:33 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30243