starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14784] [CLOSED] [WIP] Assign shorthand to every long namespace we use #30255

New Issue
Open
opened 2026-01-31 09:39:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14784
Author: @DHowett
Created: 2/4/2023
Status: ❌ Closed

Base: main ← Head: dev/duhowett/shorthand-namespaces

📝 Commits (6)

  • dd34262 Underpinnings: include something in all pch
  • 072ba2d Rename a bunch of namespaces...
  • c72c0f5 Remove the old convenience aliases
  • 95e31dd Find places where we used [[[[[winrt::]Microsoft::]Terminal::]Settings::]Model::]XXX, convert all to MTSM::XXX
  • ce44179 Same as prior, but for enums
  • fafe65d Regex too big, broke AppCommandlineArgs

📊 Changes

287 files changed (+3367 additions, -3345 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/ColorSchemeTests.cpp (+1 -1)
📝 src/cascadia/LocalTests_SettingsModel/CommandTests.cpp (+3 -3)
📝 src/cascadia/LocalTests_SettingsModel/DeserializationTests.cpp (+4 -4)
📝 src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp (+3 -3)
📝 src/cascadia/LocalTests_SettingsModel/NewTabMenuTests.cpp (+2 -2)
📝 src/cascadia/LocalTests_SettingsModel/ProfileTests.cpp (+1 -1)
📝 src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp (+2 -2)
📝 src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp (+2 -2)
📝 src/cascadia/LocalTests_SettingsModel/TestUtils.h (+3 -3)
📝 src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp (+9 -9)
📝 src/cascadia/LocalTests_SettingsModel/pch.h (+2 -1)
📝 src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp (+5 -5)
📝 src/cascadia/LocalTests_TerminalApp/CppWinrtTailored.h (+1 -1)
📝 src/cascadia/LocalTests_TerminalApp/FilteredCommandTests.cpp (+33 -33)
📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+13 -13)
📝 src/cascadia/LocalTests_TerminalApp/TabTests.cpp (+39 -46)
📝 src/cascadia/LocalTests_TerminalApp/pch.h (+2 -1)
📝 src/cascadia/Remoting/CommandlineArgs.cpp (+1 -1)
📝 src/cascadia/Remoting/GetWindowLayoutArgs.h (+1 -1)
📝 src/cascadia/Remoting/Monarch.cpp (+9 -9)

...and 80 more files

📄 Description

dustin you can't just submit a 3.8k line change over the weekend and not explain it
dustin wait

Summary of the Pull Request

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14784 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 2/4/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/duhowett/shorthand-namespaces` --- ### 📝 Commits (6) - [`dd34262`](https://github.com/microsoft/terminal/commit/dd34262f7854cc1ae7a76c35bd096ca4af1dd9e8) Underpinnings: include something in all pch - [`072ba2d`](https://github.com/microsoft/terminal/commit/072ba2d88f61b54ae6439b8da0977121baa455cb) Rename a bunch of namespaces... - [`c72c0f5`](https://github.com/microsoft/terminal/commit/c72c0f5f89e9ab1da6c8b0e0c6627cc87bbf78f2) Remove the old convenience aliases - [`95e31dd`](https://github.com/microsoft/terminal/commit/95e31ddde60b58003b2682afb6a1d8bca8fbe2bb) Find places where we used [[[[[winrt::]Microsoft::]Terminal::]Settings::]Model::]XXX, convert all to MTSM::XXX - [`ce44179`](https://github.com/microsoft/terminal/commit/ce4417971dbb58fd98bead5d0ad2b17c84e1dc15) Same as prior, but for enums - [`fafe65d`](https://github.com/microsoft/terminal/commit/fafe65d6c1d57702eb24414e50a93a31cf4450e9) Regex too big, broke AppCommandlineArgs ### 📊 Changes **287 files changed** (+3367 additions, -3345 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/ColorSchemeTests.cpp` (+1 -1) 📝 `src/cascadia/LocalTests_SettingsModel/CommandTests.cpp` (+3 -3) 📝 `src/cascadia/LocalTests_SettingsModel/DeserializationTests.cpp` (+4 -4) 📝 `src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp` (+3 -3) 📝 `src/cascadia/LocalTests_SettingsModel/NewTabMenuTests.cpp` (+2 -2) 📝 `src/cascadia/LocalTests_SettingsModel/ProfileTests.cpp` (+1 -1) 📝 `src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp` (+2 -2) 📝 `src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp` (+2 -2) 📝 `src/cascadia/LocalTests_SettingsModel/TestUtils.h` (+3 -3) 📝 `src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp` (+9 -9) 📝 `src/cascadia/LocalTests_SettingsModel/pch.h` (+2 -1) 📝 `src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp` (+5 -5) 📝 `src/cascadia/LocalTests_TerminalApp/CppWinrtTailored.h` (+1 -1) 📝 `src/cascadia/LocalTests_TerminalApp/FilteredCommandTests.cpp` (+33 -33) 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+13 -13) 📝 `src/cascadia/LocalTests_TerminalApp/TabTests.cpp` (+39 -46) 📝 `src/cascadia/LocalTests_TerminalApp/pch.h` (+2 -1) 📝 `src/cascadia/Remoting/CommandlineArgs.cpp` (+1 -1) 📝 `src/cascadia/Remoting/GetWindowLayoutArgs.h` (+1 -1) 📝 `src/cascadia/Remoting/Monarch.cpp` (+9 -9) _...and 80 more files_ </details> ### 📄 Description dustin you can't just submit a 3.8k line change over the weekend and not explain it dustin wait ## Summary of the Pull Request ## References and Relevant Issues ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed ## PR Checklist - [ ] Closes #xxx - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?