starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14869] [MERGED] Move to CppWinRT 2.0.230207.1 #30285

New Issue
Open
opened 2026-01-31 09:39:49 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:49 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14869
Author: @DHowett
Created: 2/17/2023
Status: ✅ Merged
Merged: 2/18/2023
Merged by: @DHowett

Base: main ← Head: dev/duhowett/2023-compiler/4-cppwinrt

📝 Commits (3)

  • 83cd359 Move to CppWinRT 2.0.230207.1
  • 1b00fe2 Fix ambiguous conversions of til::color to W::U::Color
  • 378bc61 Clean up one co_await of an std::chrono::duration

📊 Changes

9 files changed (+11 additions, -11 deletions)

View changed files

📝 dep/nuget/packages.config (+1 -1)
📝 scratch/ScratchIslandApp/SampleApp/packages.config (+1 -1)
📝 scratch/ScratchIslandApp/WindowExe/packages.config (+1 -1)
📝 src/cascadia/TerminalApp/Pane.cpp (+1 -1)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+1 -1)
📝 src/common.nugetversions.props (+1 -1)
📝 src/common.nugetversions.targets (+3 -3)

📄 Description

Interesting things we could do after this:

  • remove all InitializeComponent calls - they do it automatically
  • have some Clang support (!)
  • use std::optional<->IReference automatic binding
  • use std::format support (!) for json/uri/hostname/http stuff/all IStringables
  • potentially move to /await:strict for C++20 coroutines

I've also fixed up a couple ambiguities introduced by this change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14869 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 2/17/2023 **Status:** ✅ Merged **Merged:** 2/18/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/2023-compiler/4-cppwinrt` --- ### 📝 Commits (3) - [`83cd359`](https://github.com/microsoft/terminal/commit/83cd3593e66f4596008cd3b8a260519777a8c5da) Move to CppWinRT 2.0.230207.1 - [`1b00fe2`](https://github.com/microsoft/terminal/commit/1b00fe284b26d15a459c3046033ac3955a8eb7b1) Fix ambiguous conversions of til::color to W::U::Color - [`378bc61`](https://github.com/microsoft/terminal/commit/378bc6110a15d26006400dae8240e68ed38afa5e) Clean up one co_await of an std::chrono::duration ### 📊 Changes **9 files changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `dep/nuget/packages.config` (+1 -1) 📝 `scratch/ScratchIslandApp/SampleApp/packages.config` (+1 -1) 📝 `scratch/ScratchIslandApp/WindowExe/packages.config` (+1 -1) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+1 -1) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+1 -1) 📝 `src/common.nugetversions.props` (+1 -1) 📝 `src/common.nugetversions.targets` (+3 -3) </details> ### 📄 Description Interesting things we could do after this: - remove all `InitializeComponent` calls - they do it automatically - have some Clang support (!) - use `std::optional`<->`IReference` automatic binding - use `std::format` support (!) for json/uri/hostname/http stuff/all `IStringable`s - potentially move to `/await:strict` for C++20 coroutines I've also fixed up a couple ambiguities introduced by this change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?