starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14871] [MERGED] Fix a number of minor correctness issues that Clang flagged #30293

New Issue
Open
opened 2026-01-31 09:39:54 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:39:54 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14871
Author: @DHowett
Created: 2/17/2023
Status: ✅ Merged
Merged: 2/18/2023
Merged by: @DHowett

Base: main ← Head: dev/duhowett/2023-compiler/1-misc

📝 Commits (7)

  • d20fe26 lld-link: .def keywords should be uppercase
  • d479567 nodiscard must precede virtual/static
  • a9527d6 standardize precomp.h inclusion on "" instead of <>
  • 2752f0b correctness: don't co_await Dispatcher directly
  • 3883d3b Avoid calling the CharReaderBuilder constructor directly
  • 278b183 Avoid calling the StreamWriterBuilder constructor directly
  • fe85c4a ClipboardTests: construct KeyEvents directly instead of via copy

📊 Changes

16 files changed (+32 additions, -32 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/JsonTestClass.h (+2 -2)
📝 src/cascadia/TerminalControl/TermControl.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.cpp (+3 -3)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsModel/Command.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal/BaseWindow.h (+1 -1)
📝 src/host/ut_host/ClipboardTests.cpp (+5 -5)
📝 src/propsheet/console.def (+2 -2)
📝 src/propslib/DelegationConfig.cpp (+1 -1)
📝 src/renderer/inc/IRenderEngine.hpp (+8 -8)
📝 src/terminal/adapter/adaptDispatchGraphics.cpp (+1 -1)
📝 src/terminal/adapter/telemetry.cpp (+1 -1)
📝 src/terminal/parser/telemetry.cpp (+1 -1)
📝 src/tools/lnkd/main.cpp (+1 -1)
📝 src/tools/pixels/main.cpp (+1 -1)
📝 src/tools/test/main.cpp (+1 -1)

📄 Description

  • lld-link is more strict about the casing of keywords in .def files
  • [[nodiscard]] must come before virtual and static qualifiers
  • precomp.h is never to be included with <>
  • We were calling the jsoncpp constructors directly (oops) as functions (oops)
  • ClipboardTests constructed KeyEvents by copy instead of directly

I don't know about the Dispatcher one, but it looks more correct this way. Also, it compiles. That was done before the C++/WinRT update, so maybe they fixed it as well.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14871 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 2/17/2023 **Status:** ✅ Merged **Merged:** 2/18/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/2023-compiler/1-misc` --- ### 📝 Commits (7) - [`d20fe26`](https://github.com/microsoft/terminal/commit/d20fe263f9a5ccbbffadb52072fca5799efdb4b9) lld-link: .def keywords should be uppercase - [`d479567`](https://github.com/microsoft/terminal/commit/d47956700e34ab08c40b35b74b6337baeb0fb562) nodiscard must precede virtual/static - [`a9527d6`](https://github.com/microsoft/terminal/commit/a9527d6c8653380998d814d6ca1003fa5e9aae32) standardize precomp.h inclusion on "" instead of <> - [`2752f0b`](https://github.com/microsoft/terminal/commit/2752f0bcbaa147dc56ecfd009467c1cdebd4170d) correctness: don't co_await Dispatcher directly - [`3883d3b`](https://github.com/microsoft/terminal/commit/3883d3bd071504189544c8cec3fafcc8f676773d) Avoid calling the CharReaderBuilder constructor directly - [`278b183`](https://github.com/microsoft/terminal/commit/278b183bf07420e58ced289ca62accea91008b9d) Avoid calling the StreamWriterBuilder constructor directly - [`fe85c4a`](https://github.com/microsoft/terminal/commit/fe85c4aa2327550405636ea1f4af41309732c757) ClipboardTests: construct KeyEvents directly instead of via copy ### 📊 Changes **16 files changed** (+32 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/JsonTestClass.h` (+2 -2) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.cpp` (+3 -3) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/Command.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal/BaseWindow.h` (+1 -1) 📝 `src/host/ut_host/ClipboardTests.cpp` (+5 -5) 📝 `src/propsheet/console.def` (+2 -2) 📝 `src/propslib/DelegationConfig.cpp` (+1 -1) 📝 `src/renderer/inc/IRenderEngine.hpp` (+8 -8) 📝 `src/terminal/adapter/adaptDispatchGraphics.cpp` (+1 -1) 📝 `src/terminal/adapter/telemetry.cpp` (+1 -1) 📝 `src/terminal/parser/telemetry.cpp` (+1 -1) 📝 `src/tools/lnkd/main.cpp` (+1 -1) 📝 `src/tools/pixels/main.cpp` (+1 -1) 📝 `src/tools/test/main.cpp` (+1 -1) </details> ### 📄 Description * `lld-link` is more strict about the casing of keywords in `.def` files * `[[nodiscard]]` must come before `virtual` and `static` qualifiers * `precomp.h` is never to be included with `<>` * We were calling the jsoncpp constructors directly (oops) as functions (oops) * ClipboardTests constructed `KeyEvent`s by copy instead of directly I don't know about the Dispatcher one, but it looks more correct this way. Also, it compiles. That was done before the C++/WinRT update, so maybe they fixed it as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:39:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30293
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?