[PR #14943] [MERGED] Add support for opening the Suggestions UI with recent commands #30312

Open
opened 2026-01-31 09:40:01 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14943
Author: @zadjii-msft
Created: 3/2/2023
Status: Merged
Merged: 8/15/2023
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/f/14779-sxnui-recent-commands


📝 Commits (10+)

  • c96799c Preview the input via the TSF input control. This is awesome, and should go into main
  • 1449088 bugfixes for the demo
  • d3b5533 fix remaining bugs
  • 0bda66f a comment I missed
  • ccfc834 Migrate spelling-0.0.21 changes from main
  • c97ac66 resart with fresh plumbing
  • 7404dc3 zhu li, do the thing
  • f361b6c lots of removal of dead code from the sxnui
  • b0fa972 make the menu mode compact, and remove the search box
  • 985fcdb better UX for typing

📊 Changes

18 files changed (+212 additions, -16 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+28 -0)
📝 src/cascadia/TerminalApp/SuggestionsControl.cpp (+17 -15)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+36 -0)
📝 src/cascadia/TerminalControl/ControlCore.h (+12 -0)
📝 src/cascadia/TerminalControl/ControlCore.idl (+7 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+4 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.idl (+1 -0)
📝 src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.cpp (+11 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.h (+8 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+13 -0)
📝 src/cascadia/TerminalSettingsModel/AllShortcutActions.h (+2 -0)
📝 src/cascadia/TerminalSettingsModel/Command.cpp (+49 -0)
📝 src/cascadia/TerminalSettingsModel/Command.h (+3 -0)
📝 src/cascadia/TerminalSettingsModel/Command.idl (+2 -0)
📝 src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw (+7 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+9 -0)

📄 Description

⚠️ targets #14938 ⚠️

This adds support for a new action, showSuggestions, as described in #14864. This adds just one source currently, recentCommands. This requires shell integration to be enabled in the shell to work properly. When it is enabled, activating that action will invoke the suggestions UI as a palette, populated with sendInput actions for each of the user's recent commands.

  • These don't persist across reboots.
  • These are per-control.

There's mild plans to remedy that in a follow-up, though that needs a bit more design consideration.

Closes #14779

gh-14779-recent-commands-for-pr


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14943 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/2/2023 **Status:** ✅ Merged **Merged:** 8/15/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/f/14779-sxnui-recent-commands` --- ### 📝 Commits (10+) - [`c96799c`](https://github.com/microsoft/terminal/commit/c96799c6e9d84b5968f8841633c6d74480f91d02) Preview the input via the TSF input control. This is awesome, and should go into main - [`1449088`](https://github.com/microsoft/terminal/commit/1449088e80b81d82cbf5456baaf69798ee849d16) bugfixes for the demo - [`d3b5533`](https://github.com/microsoft/terminal/commit/d3b5533a1eef45edbfbae4e68ee7e9507c97406c) fix remaining bugs - [`0bda66f`](https://github.com/microsoft/terminal/commit/0bda66fc2f0f5d6a5e709d8ebc4678256d132fc3) a comment I missed - [`ccfc834`](https://github.com/microsoft/terminal/commit/ccfc83443be754abac5be2200e3df05a8ae6f2ca) Migrate spelling-0.0.21 changes from main - [`c97ac66`](https://github.com/microsoft/terminal/commit/c97ac66d5df89e046bd46c7838269867c9dbb3c1) resart with fresh plumbing - [`7404dc3`](https://github.com/microsoft/terminal/commit/7404dc3d35fa2fe8e73df27caa9fa910b4b86738) zhu li, do the thing - [`f361b6c`](https://github.com/microsoft/terminal/commit/f361b6c8792a9b94b4fb2328b8f23ac1dd7fe100) lots of removal of dead code from the sxnui - [`b0fa972`](https://github.com/microsoft/terminal/commit/b0fa972ec16dd11153ba7dd8bacd5f449af923d3) make the menu mode compact, and remove the search box - [`985fcdb`](https://github.com/microsoft/terminal/commit/985fcdbdb6c6bab444bdfa804325b80358f6dee7) better UX for typing ### 📊 Changes **18 files changed** (+212 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+28 -0) 📝 `src/cascadia/TerminalApp/SuggestionsControl.cpp` (+17 -15) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+36 -0) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+12 -0) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+7 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+4 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.cpp` (+11 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.h` (+8 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+13 -0) 📝 `src/cascadia/TerminalSettingsModel/AllShortcutActions.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/Command.cpp` (+49 -0) 📝 `src/cascadia/TerminalSettingsModel/Command.h` (+3 -0) 📝 `src/cascadia/TerminalSettingsModel/Command.idl` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw` (+7 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+9 -0) </details> ### 📄 Description _⚠️ targets #14938 ⚠️_ This adds support for a new action, `showSuggestions`, as described in #14864. This adds just one `source` currently, `recentCommands`. This requires shell integration to be enabled in the shell to work properly. When it is enabled, activating that action will invoke the suggestions UI as a palette, populated with `sendInput` actions for each of the user's recent commands. * These don't persist across reboots. * These are per-control. There's mild plans to remedy that in a follow-up, though that needs a bit more design consideration. Closes #14779 ![gh-14779-recent-commands-for-pr](https://user-images.githubusercontent.com/18356694/222550835-f254198f-202f-4f1b-950f-19d1c868bfa7.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:01 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30312