starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14947] Add pre-build PowerShell version check #30326

New Issue
Open
opened 2026-01-31 09:40:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:40:07 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/14947

State: closed
Merged: Yes

Summary of the Pull Request

Two PowerShell scripts were added so that developers new to the project know if they have the wrong version of PowerShell installed.

Detailed Description of the Pull Request / Additional comments

When first building Terminal, it would continuously fail, and I didn't really know why. I'm new to both this project and to open source, so when I saw this,
image
I was confused and didn't know what went wrong. What I didn't know is that Windows PowerShell and PowerShell Core had different names for their .exe files, and since I had the latest version of Windows PowerShell installed, I figured that I was completely set. So, once I realized that Windows PowerShell (what I had installed) is powershell.exe and PowerShell Core (what I needed to have installed) is pwsh.exe, I downloaded PowerShell Core, and it built without issue. So, in order to help other newbies, I made two scripts, CheckPSVersion and WindowsCheckPSVersion, which make sure that PowerShell Core 7.0.0+ is installed, outputting an error telling the developer to download Core 7.0.0+ if they have Windows PowerShell but not Core. These scripts are run pre-build courtesy of Microsoft.Terminal.Settings.ModelLib.vcxproj

As I said, I'm new here, so any feedback is more than welcome!

Validation Steps Performed

Building with both Windows PowerShell and PowerShell core: builds perfectly, no issues.
Building with Windows PowerShell but not PowerShell core: build fails, but a nice error prints out that reminds the user to download the correct version of PowerShell core.

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/14947 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Two PowerShell scripts were added so that developers new to the project know if they have the wrong version of PowerShell installed. ## Detailed Description of the Pull Request / Additional comments When first building Terminal, it would continuously fail, and I didn't really know why. I'm new to both this project and to open source, so when I saw this, ![image](https://user-images.githubusercontent.com/81830231/222797783-723314cb-0220-4aa8-9bcd-22f0c08d27f0.png) I was confused and didn't know what went wrong. What I didn't know is that Windows PowerShell and PowerShell Core had different names for their .exe files, and since I had the latest version of Windows PowerShell installed, I figured that I was completely set. So, once I realized that Windows PowerShell (what I had installed) is powershell.exe and PowerShell Core (what I needed to have installed) is pwsh.exe, I downloaded PowerShell Core, and it built without issue. So, in order to help other newbies, I made two scripts, `CheckPSVersion` and `WindowsCheckPSVersion`, which make sure that PowerShell Core 7.0.0+ is installed, outputting an error telling the developer to download Core 7.0.0+ if they have Windows PowerShell but not Core. These scripts are run pre-build courtesy of `Microsoft.Terminal.Settings.ModelLib.vcxproj` As I said, I'm new here, so any feedback is more than welcome! ## Validation Steps Performed Building with both Windows PowerShell and PowerShell core: builds perfectly, no issues. Building with Windows PowerShell but not PowerShell core: build fails, but a nice error prints out that reminds the user to download the correct version of PowerShell core. ## PR Checklist - [x] Closes #14797 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)
claunia added the pull-request label 2026-01-31 09:40:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30326
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?