starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #14991] [MERGED] Fix console aliases not working #30330

New Issue
Open
opened 2026-01-31 09:40:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:40:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/14991
Author: @lhecker
Created: 3/14/2023
Status: ✅ Merged
Merged: 3/17/2023
Merged by: @carlos-zamora

Base: main ← Head: dev/lhecker/8000-TranslateUnicodeToOem-fixup

📝 Commits (3)

  • 612baad Fix console aliases not working
  • 470b02c Fix formatting
  • 1924a7e Defensive coding practices sponsored by MtnDustin

📊 Changes

4 files changed (+47 additions, -40 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -18)
📝 src/host/inputReadHandleData.cpp (+1 -1)
📝 src/host/readDataCooked.cpp (+27 -11)
📝 src/host/stream.cpp (+18 -10)

📄 Description

#14745 contains two regressions related to console alias handling:

  • When ProcessAliases expands the backup buffer into (an) aliased
    command(s) it changes the _bytesRead field of COOKED_READ_DATA,
    requiring us to re-read it and reconstruct the input string-view.
  • Multiline aliases are read line-by-line whereas #14745 didn't treat
    them any different from regular single-line inputs.

Validation Steps Performed

In cmd.exe run

doskey test=echo foo$Techo bar$Techo baz
test

The output should look exactly like this:

C:\>doskey test=echo foo$Techo bar$Techo baz

C:\>test
foo

C:\>bar

C:\>baz

C:\>

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/14991 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 3/14/2023 **Status:** ✅ Merged **Merged:** 3/17/2023 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `main` ← **Head:** `dev/lhecker/8000-TranslateUnicodeToOem-fixup` --- ### 📝 Commits (3) - [`612baad`](https://github.com/microsoft/terminal/commit/612baadff896284f1fa0844fdfc370978d125bad) Fix console aliases not working - [`470b02c`](https://github.com/microsoft/terminal/commit/470b02c70b965b92ecd0a09a56ccce9703033d0e) Fix formatting - [`1924a7e`](https://github.com/microsoft/terminal/commit/1924a7ec775a15825268fac2c1b32d19fc2b93a5) Defensive coding practices sponsored by MtnDustin ### 📊 Changes **4 files changed** (+47 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -18) 📝 `src/host/inputReadHandleData.cpp` (+1 -1) 📝 `src/host/readDataCooked.cpp` (+27 -11) 📝 `src/host/stream.cpp` (+18 -10) </details> ### 📄 Description #14745 contains two regressions related to console alias handling: * When `ProcessAliases` expands the backup buffer into (an) aliased command(s) it changes the `_bytesRead` field of `COOKED_READ_DATA`, requiring us to re-read it and reconstruct the `input` string-view. * Multiline aliases are read line-by-line whereas #14745 didn't treat them any different from regular single-line inputs. ## Validation Steps Performed In `cmd.exe` run ``` doskey test=echo foo$Techo bar$Techo baz test ``` The output should look exactly like this: ``` C:\>doskey test=echo foo$Techo bar$Techo baz C:\>test foo C:\>bar C:\>baz C:\> ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?