[PR #15011] [MERGED] Fix some simple C# linter warnings #30351

Open
opened 2026-01-31 09:40:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15011
Author: @zadjii-msft
Created: 3/17/2023
Status: Merged
Merged: 3/17/2023
Merged by: @DHowett

Base: mainHead: dev/migrie/b/silly-warnings


📝 Commits (1)

📊 Changes

1 file changed (+18 additions, -17 deletions)

View changed files

📝 src/cascadia/WpfTerminalControl/TerminalControl.xaml.cs (+18 -17)

📄 Description

Azure Devops jumps to these as the first "error" when you open a failing build. But these are warnings, not errors. So you're left hunting for the real error. If only someone had scrollbar marks for indicating lines with error messages...

May as well clean them up.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15011 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/17/2023 **Status:** ✅ Merged **Merged:** 3/17/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/b/silly-warnings` --- ### 📝 Commits (1) - [`e142542`](https://github.com/microsoft/terminal/commit/e142542a29354b8a78ce1c89ac0806b1fd42d297) while I'm here ### 📊 Changes **1 file changed** (+18 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WpfTerminalControl/TerminalControl.xaml.cs` (+18 -17) </details> ### 📄 Description Azure Devops jumps to these as the first "error" when you open a failing build. But these are warnings, not errors. So you're left hunting for the real error. _If only someone had scrollbar marks for indicating lines with error messages..._ May as well clean them up. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:16 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30351