[PR #15020] [MERGED] Add buttons for selecting commands, output to context menu #30352

Open
opened 2026-01-31 09:40:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15020
Author: @zadjii-msft
Created: 3/20/2023
Status: Merged
Merged: 4/25/2023
Merged by: @microsoft-github-policy-service[bot]

Base: mainHead: dev/migrie/f/rclick-select-command


📝 Commits (10+)

  • eaf1a92 okay maybe I have silly free time ideas too
  • 7001e93 forwarded_event, string tests
  • eb88cd3 practical use, look
  • b535a5f I suppose this is what happens when I have four uninterrupted hours away from the kid
  • 520c89f sad beeps
  • eb7d2be I am incapable of not making 100 tiny commits, this was already way to friggin big.
  • e6b33c3 yea that's everything
  • 29d454b 90% plumbing, 10% bad implementation of making sure we right-clicked then released
  • 451d8f3 move this code to interactivity. Scaling of event is wrong now
  • 99b84a6 Merge remote-tracking branch 'origin/main' into dev/migrie/f/3337-just-for-funsies

📊 Changes

12 files changed (+249 additions, -19 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+120 -14)
📝 src/cascadia/TerminalControl/ControlCore.h (+20 -0)
📝 src/cascadia/TerminalControl/ControlCore.idl (+5 -0)
📝 src/cascadia/TerminalControl/ControlInteractivity.cpp (+5 -0)
📝 src/cascadia/TerminalControl/Resources/en-US/Resources.resw (+32 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+24 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+7 -4)
📝 src/cascadia/TerminalControl/TermControl.xaml (+28 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+1 -0)
📝 src/inc/til/coalesce.h (+1 -1)
📝 src/terminal/adapter/DispatchTypes.hpp (+5 -0)

📄 Description

Adds a "Select command" and a "Select output" entry to the right-click context menu when the user has shell integration enabled. This lets the user quickly right-click on a command and select the entire commandline or all of its output.

This was a "I'm waiting for reviews" sorta idea. Seemed like a reasonable combination of features. Related to #13445, #11000.

Tested manually.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15020 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/20/2023 **Status:** ✅ Merged **Merged:** 4/25/2023 **Merged by:** [@microsoft-github-policy-service[bot]](https://github.com/apps/microsoft-github-policy-service) **Base:** `main` ← **Head:** `dev/migrie/f/rclick-select-command` --- ### 📝 Commits (10+) - [`eaf1a92`](https://github.com/microsoft/terminal/commit/eaf1a920e1a4d5a4ea349ed0036f3fa520709212) okay maybe I have silly free time ideas too - [`7001e93`](https://github.com/microsoft/terminal/commit/7001e93550ef6ac182b7bb6aaaf3a0acbdbe2b82) forwarded_event, string tests - [`eb88cd3`](https://github.com/microsoft/terminal/commit/eb88cd3a2d15fbf30af64a70f2ef859173388a40) practical use, look - [`b535a5f`](https://github.com/microsoft/terminal/commit/b535a5f3f359b95156119679a144e0f7ada9ce4e) I suppose this is what happens when I have four uninterrupted hours away from the kid - [`520c89f`](https://github.com/microsoft/terminal/commit/520c89f1fe236c2684f7f2a8434d7e8157e3b597) sad beeps - [`eb7d2be`](https://github.com/microsoft/terminal/commit/eb7d2be2e8c7d447b50ea2f4dae277743d4caa3d) I am incapable of not making 100 tiny commits, this was already way to friggin big. - [`e6b33c3`](https://github.com/microsoft/terminal/commit/e6b33c37400a46bc49fac2a3febbaabd418f12ad) yea that's everything - [`29d454b`](https://github.com/microsoft/terminal/commit/29d454ba4c6d2297726bd2bd1e049aab7a8f1b8b) 90% plumbing, 10% bad implementation of making sure we right-clicked then released - [`451d8f3`](https://github.com/microsoft/terminal/commit/451d8f360928105823a944258f761541fc6d84fa) move this code to interactivity. Scaling of event is wrong now - [`99b84a6`](https://github.com/microsoft/terminal/commit/99b84a60b76457253fa925cba61b546de1127d96) Merge remote-tracking branch 'origin/main' into dev/migrie/f/3337-just-for-funsies ### 📊 Changes **12 files changed** (+249 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+120 -14) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+20 -0) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+5 -0) 📝 `src/cascadia/TerminalControl/ControlInteractivity.cpp` (+5 -0) 📝 `src/cascadia/TerminalControl/Resources/en-US/Resources.resw` (+32 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+24 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+7 -4) 📝 `src/cascadia/TerminalControl/TermControl.xaml` (+28 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+1 -0) 📝 `src/inc/til/coalesce.h` (+1 -1) 📝 `src/terminal/adapter/DispatchTypes.hpp` (+5 -0) </details> ### 📄 Description Adds a "Select command" and a "Select output" entry to the right-click context menu when the user has shell integration enabled. This lets the user quickly right-click on a command and select the entire commandline or all of its output. This was a "I'm waiting for reviews" sorta idea. Seemed like a reasonable combination of features. Related to #13445, #11000. Tested manually. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:16 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30352