[PR #15027] [MERGED] Add a useCommandline property to the suggestions action #30353

Open
opened 2026-01-31 09:40:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15027
Author: @zadjii-msft
Created: 3/21/2023
Status: ✅ Merged
Merged: 8/15/2023
Merged by: @zadjii-msft

Base: main ← Head: dev/migrie/f/sxnui-useCommandline


📝 Commits (10+)

  • c96799c Preview the input via the TSF input control. This is awesome, and should go into main
  • 1449088 bugfixes for the demo
  • d3b5533 fix remaining bugs
  • 0bda66f a comment I missed
  • ccfc834 Migrate spelling-0.0.21 changes from main
  • c97ac66 resart with fresh plumbing
  • 7404dc3 zhu li, do the thing
  • f361b6c lots of removal of dead code from the sxnui
  • b0fa972 make the menu mode compact, and remove the search box
  • 985fcdb better UX for typing

📊 Changes

16 files changed (+101 additions, -41 deletions)

View changed files

📝 src/buffer/out/textBuffer.cpp (+16 -0)
📝 src/buffer/out/textBuffer.hpp (+1 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+4 -2)
📝 src/cascadia/TerminalApp/SuggestionsControl.cpp (+4 -0)
📝 src/cascadia/TerminalApp/SuggestionsControl.h (+1 -0)
📝 src/cascadia/TerminalApp/SuggestionsControl.idl (+1 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+10 -3)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -1)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+3 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+10 -0)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.cpp (+13 -2)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.h (+3 -2)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+2 -1)
📝 src/cascadia/TerminalSettingsModel/Command.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw (+27 -27)

📄 Description

targets #14943

When this is true, this will re-use the existing commandline to pre-filter the results. This is especially helpful for completing a suggestion based on the text that's already been typed.

Like with command history, this requires that shell integration is enabled before it will work.## Summary of the Pull Request

References and Relevant Issues

See also #13445
As spec'd in #14864

Validation Steps Performed

Tested manually


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15027 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/21/2023 **Status:** ✅ Merged **Merged:** 8/15/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/f/sxnui-useCommandline` --- ### 📝 Commits (10+) - [`c96799c`](https://github.com/microsoft/terminal/commit/c96799c6e9d84b5968f8841633c6d74480f91d02) Preview the input via the TSF input control. This is awesome, and should go into main - [`1449088`](https://github.com/microsoft/terminal/commit/1449088e80b81d82cbf5456baaf69798ee849d16) bugfixes for the demo - [`d3b5533`](https://github.com/microsoft/terminal/commit/d3b5533a1eef45edbfbae4e68ee7e9507c97406c) fix remaining bugs - [`0bda66f`](https://github.com/microsoft/terminal/commit/0bda66fc2f0f5d6a5e709d8ebc4678256d132fc3) a comment I missed - [`ccfc834`](https://github.com/microsoft/terminal/commit/ccfc83443be754abac5be2200e3df05a8ae6f2ca) Migrate spelling-0.0.21 changes from main - [`c97ac66`](https://github.com/microsoft/terminal/commit/c97ac66d5df89e046bd46c7838269867c9dbb3c1) resart with fresh plumbing - [`7404dc3`](https://github.com/microsoft/terminal/commit/7404dc3d35fa2fe8e73df27caa9fa910b4b86738) zhu li, do the thing - [`f361b6c`](https://github.com/microsoft/terminal/commit/f361b6c8792a9b94b4fb2328b8f23ac1dd7fe100) lots of removal of dead code from the sxnui - [`b0fa972`](https://github.com/microsoft/terminal/commit/b0fa972ec16dd11153ba7dd8bacd5f449af923d3) make the menu mode compact, and remove the search box - [`985fcdb`](https://github.com/microsoft/terminal/commit/985fcdbdb6c6bab444bdfa804325b80358f6dee7) better UX for typing ### 📊 Changes **16 files changed** (+101 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/textBuffer.cpp` (+16 -0) 📝 `src/buffer/out/textBuffer.hpp` (+1 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+4 -2) 📝 `src/cascadia/TerminalApp/SuggestionsControl.cpp` (+4 -0) 📝 `src/cascadia/TerminalApp/SuggestionsControl.h` (+1 -0) 📝 `src/cascadia/TerminalApp/SuggestionsControl.idl` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+10 -3) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -1) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+3 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+10 -0) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.cpp` (+13 -2) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.h` (+3 -2) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/Command.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw` (+27 -27) </details> ### 📄 Description _targets #14943_ When this is true, this will re-use the existing commandline to pre-filter the results. This is especially helpful for completing a suggestion based on the text that's already been typed. Like with command history, this requires that shell integration is enabled before it will work.## Summary of the Pull Request ## References and Relevant Issues See also #13445 As spec'd in #14864 ## Validation Steps Performed Tested manually --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30353