[PR #15030] [MERGED] Fix wt -w _quake by not throwing when setting the window name #30364

Open
opened 2026-01-31 09:40:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15030
Author: @zadjii-msft
Created: 3/22/2023
Status: Merged
Merged: 3/24/2023
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/b/of-the-darkening-of-valinor


📝 Commits (2)

  • 99beb16 Fix wt -w _quake by not throwing when setting the window name
  • b1f9c03 thanks VS

📊 Changes

1 file changed (+13 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalWindow.cpp (+13 -2)

📄 Description

If we get initialized with a window name, this will be called before XAML is stood up, and constructing a PropertyChangedEventArgs will throw. So don't.

Regressed in #14843

Related to #5000, #14957


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15030 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/22/2023 **Status:** ✅ Merged **Merged:** 3/24/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/b/of-the-darkening-of-valinor` --- ### 📝 Commits (2) - [`99beb16`](https://github.com/microsoft/terminal/commit/99beb1659f23db801955cf6cd30feb71f11ba493) Fix `wt -w _quake` by not throwing when setting the window name - [`b1f9c03`](https://github.com/microsoft/terminal/commit/b1f9c03d17e3c5835d4c21231a103c24cae40e8a) thanks VS ### 📊 Changes **1 file changed** (+13 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalWindow.cpp` (+13 -2) </details> ### 📄 Description If we get initialized with a window name, this will be called before XAML is stood up, and constructing a PropertyChangedEventArgs will throw. So don't. Regressed in #14843 Related to #5000, #14957 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30364