[PR #15039] [MERGED] Clean up more warnings #30369

Open
opened 2026-01-31 09:40:24 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15039
Author: @zadjii-msft
Created: 3/23/2023
Status: Merged
Merged: 3/24/2023
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/b/more-warnings


📝 Commits (1)

📊 Changes

3 files changed (+27 additions, -28 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/AddProfile.xaml (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+2 -2)
📝 src/cascadia/WpfTerminalControl/TerminalContainer.cs (+24 -25)

📄 Description

  • These Icon bindings were to Profiles which aren't Observable, but it also doesn't matter
  • More c# warnings

hopefully we'll just jump straight to real errors now.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15039 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/23/2023 **Status:** ✅ Merged **Merged:** 3/24/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/b/more-warnings` --- ### 📝 Commits (1) - [`f7616a0`](https://github.com/microsoft/terminal/commit/f7616a0c34da40ad6fdb73daaed789eaec2cd8f4) clean up more warnings ### 📊 Changes **3 files changed** (+27 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/AddProfile.xaml` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+2 -2) 📝 `src/cascadia/WpfTerminalControl/TerminalContainer.cs` (+24 -25) </details> ### 📄 Description * These `Icon` bindings were to `Profile`s which aren't Observable, but it also doesn't matter * More c# warnings hopefully we'll just jump straight to real errors now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:24 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30369