[PR #15082] [MERGED] Support environment variables in the settings #30390

Open
opened 2026-01-31 09:40:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15082
Author: @ianjoneill
Created: 4/1/2023
Status: Merged
Merged: 4/12/2023
Merged by: @DHowett

Base: mainHead: feature/2785-profile-env-vars-with-string-map


📝 Commits (10+)

  • b0c426b implement env vars in settings (#2785)
  • 5036cb0 Invoke-CodeFormat
  • b4efbb8 Code review feedback
  • 5d68c94 Code review update (KalleOlaviNiemitalo)
  • ea56d64 Fix spelling mistake
  • 9ec2218 Merge branch 'main' into feature/2785-profile-env-vars-with-string-map
  • f1c1cc4 fix build (#2785)
  • 0b6f411 fix code formatting (#2785)
  • 46a9b35 Run unix2dos on TerminalSettings.h and Profile.h
  • ad11e67 Merge branch 'main' into feature/2785-profile-env-vars-with-string-map

📊 Changes

25 files changed (+322 additions, -262 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+7 -0)
📝 src/cascadia/LocalTests_SettingsModel/ProfileTests.cpp (+47 -0)
📝 src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp (+7 -1)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+8 -9)
📝 src/cascadia/TerminalApp/TerminalWindow.cpp (+1 -0)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+34 -37)
📝 src/cascadia/TerminalConnection/ConptyConnection.h (+3 -1)
📝 src/cascadia/TerminalConnection/ConptyConnection.idl (+2 -1)
📝 src/cascadia/TerminalControl/IControlSettings.idl (+0 -1)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+26 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Profile.h (+2 -0)
📝 src/cascadia/TerminalSettingsModel/Profile.idl (+5 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+14 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+2 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.idl (+4 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalWarnings.idl (+1 -0)
📝 src/cascadia/inc/ControlProperties.h (+0 -1)

...and 5 more files

📄 Description

Existing environment variables can be referenced by enclosing the name in percent characters (e.g. %PATH%).

Resurrects #9287 by @christapley.

Tests added and manually tested.

Closes #2785
Closes #9233

Co-authored-by: Chris Tapley chris.tapley.81@gmail.com


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15082 **Author:** [@ianjoneill](https://github.com/ianjoneill) **Created:** 4/1/2023 **Status:** ✅ Merged **Merged:** 4/12/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `feature/2785-profile-env-vars-with-string-map` --- ### 📝 Commits (10+) - [`b0c426b`](https://github.com/microsoft/terminal/commit/b0c426b455bac3b666a1a89b0a0a10e8d77c98e3) implement env vars in settings (#2785) - [`5036cb0`](https://github.com/microsoft/terminal/commit/5036cb04ba354b6297d097226732a99dd7ec75ec) Invoke-CodeFormat - [`b4efbb8`](https://github.com/microsoft/terminal/commit/b4efbb81960e4f14d40c9ee95e550ef3c6b75b67) Code review feedback - [`5d68c94`](https://github.com/microsoft/terminal/commit/5d68c94fec3902b776293aabb0bfc12ea227843b) Code review update (KalleOlaviNiemitalo) - [`ea56d64`](https://github.com/microsoft/terminal/commit/ea56d64fc41616e019aa633fb39f8ac88a12be99) Fix spelling mistake - [`9ec2218`](https://github.com/microsoft/terminal/commit/9ec221806e88d357bbc0c09b24f19c9e297d5383) Merge branch 'main' into feature/2785-profile-env-vars-with-string-map - [`f1c1cc4`](https://github.com/microsoft/terminal/commit/f1c1cc4ba476d17cf3d577f3513e50c627c1a1c9) fix build (#2785) - [`0b6f411`](https://github.com/microsoft/terminal/commit/0b6f41189025a0cf3b42b4d619fe3749bfb9d140) fix code formatting (#2785) - [`46a9b35`](https://github.com/microsoft/terminal/commit/46a9b359983f55d2f0007aa221909f801d3e4b05) Run unix2dos on TerminalSettings.h and Profile.h - [`ad11e67`](https://github.com/microsoft/terminal/commit/ad11e6723e4c57eab7596ccc644244fd31996688) Merge branch 'main' into feature/2785-profile-env-vars-with-string-map ### 📊 Changes **25 files changed** (+322 additions, -262 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+7 -0) 📝 `src/cascadia/LocalTests_SettingsModel/ProfileTests.cpp` (+47 -0) 📝 `src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp` (+7 -1) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+8 -9) 📝 `src/cascadia/TerminalApp/TerminalWindow.cpp` (+1 -0) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+34 -37) 📝 `src/cascadia/TerminalConnection/ConptyConnection.h` (+3 -1) 📝 `src/cascadia/TerminalConnection/ConptyConnection.idl` (+2 -1) 📝 `src/cascadia/TerminalControl/IControlSettings.idl` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+26 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Profile.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/Profile.idl` (+5 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+14 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.idl` (+4 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalWarnings.idl` (+1 -0) 📝 `src/cascadia/inc/ControlProperties.h` (+0 -1) _...and 5 more files_ </details> ### 📄 Description Existing environment variables can be referenced by enclosing the name in percent characters (e.g. `%PATH%`). Resurrects #9287 by @christapley. Tests added and manually tested. Closes #2785 Closes #9233 Co-authored-by: Chris Tapley <chris.tapley.81@gmail.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:33 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30390