[PR #15079] [MERGED] Fix a crash in the rclick context menu #30391

Open
opened 2026-01-31 09:40:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15079
Author: @zadjii-msft
Created: 3/31/2023
Status: Merged
Merged: 3/31/2023
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/b/context-menu-tearout-crash


📝 Commits (1)

  • 48dff47 Fix a crash in the rclick context menu

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+1 -2)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)

📄 Description

Due to a bad merge a few commits back. This event should have had a revoker.

Probably regressed in #14851


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15079 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/31/2023 **Status:** ✅ Merged **Merged:** 3/31/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/b/context-menu-tearout-crash` --- ### 📝 Commits (1) - [`48dff47`](https://github.com/microsoft/terminal/commit/48dff47bc6b388641bde356361b1d67a10c6fbb1) Fix a crash in the rclick context menu ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+1 -2) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) </details> ### 📄 Description Due to a bad merge a few commits back. This event should have had a revoker. Probably regressed in #14851 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:33 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30391