[PR #15094] [MERGED] Use DIPs for the window bounds when tearing out #30409

Open
opened 2026-01-31 09:40:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15094
Author: @zadjii-msft
Created: 4/3/2023
Status: ✅ Merged
Merged: 4/4/2023
Merged by: @zadjii-msft

Base: main ← Head: dev/migrie/oop/3/a-short-rest


📝 Commits (3)

  • 53c2669 Use DIPs for the window bounds when tearing out
  • 302c8f1 easier
  • 28f583a std::ignore the tests is what I did

📊 Changes

4 files changed (+14 additions, -14 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalWindow.cpp (+4 -4)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+6 -6)
📝 src/inc/til/size.h (+2 -2)
📝 src/til/ut_til/SizeTests.cpp (+2 -2)

📄 Description

Fixes a bug where you'd drag across the boundary and the new window would be at the wrong size

related to #14957


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15094 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/3/2023 **Status:** ✅ Merged **Merged:** 4/4/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/oop/3/a-short-rest` --- ### 📝 Commits (3) - [`53c2669`](https://github.com/microsoft/terminal/commit/53c26699ae301ea6eb31f126a2ed31d5be9d2e5e) Use DIPs for the window bounds when tearing out - [`302c8f1`](https://github.com/microsoft/terminal/commit/302c8f148cf4b740935895a2bf10380284b66bca) easier - [`28f583a`](https://github.com/microsoft/terminal/commit/28f583a8f473f9f92f7f39eb7aba92e052620d0a) std::ignore the tests is what I did ### 📊 Changes **4 files changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalWindow.cpp` (+4 -4) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+6 -6) 📝 `src/inc/til/size.h` (+2 -2) 📝 `src/til/ut_til/SizeTests.cpp` (+2 -2) </details> ### 📄 Description Fixes a bug where you'd drag across the boundary and the new window would be at the wrong size related to #14957 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30409