starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15098] [MERGED] Fix accuracy bugs around float/double/int conversions #30410

New Issue
Open
opened 2026-01-31 09:40:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:40:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15098
Author: @lhecker
Created: 4/4/2023
Status: ✅ Merged
Merged: 4/4/2023
Merged by: @DHowett

Base: main ← Head: dev/lhecker/float-double-inaccuracy-bugs

📝 Commits (2)

  • c8865d4 Fix accuracy bugs around float/double conversions
  • e2edab0 Fix compilation

📊 Changes

7 files changed (+55 additions, -59 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+17 -20)
📝 src/cascadia/TerminalControl/ControlCore.h (+9 -9)
📝 src/cascadia/TerminalControl/ControlCore.idl (+6 -6)
📝 src/cascadia/TerminalControl/TermControl.cpp (+15 -15)
📝 src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp (+3 -2)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+4 -6)
📝 src/inc/til/math.h (+1 -1)

📄 Description

I noticed this bug while resizing my window on my 150% scale display.
Every 3 "snaps" of the window size, it would fail to resize the text
buffer. I found that this occurs, because we convert the swap chain
size from a float into a double, which converts my 597.333313 height
into 597.33331298828125, which then multiplied by 1.5 results in
895.999969482421875. If you just cast this to an integer, it'll
result in a height of 895px instead of the expected 896px.

This PR addresses the issue in two ways:

  • Replace casts to integers with lrint or floor, etc.
  • Remove many of the redundant double <> float conversions.

PR Checklist

  • Resizing my window always resizes the text buffer ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15098 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 4/4/2023 **Status:** ✅ Merged **Merged:** 4/4/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/lhecker/float-double-inaccuracy-bugs` --- ### 📝 Commits (2) - [`c8865d4`](https://github.com/microsoft/terminal/commit/c8865d4d5f3a0432de530e66a55e6c608c6e980c) Fix accuracy bugs around float/double conversions - [`e2edab0`](https://github.com/microsoft/terminal/commit/e2edab097655acc45145abf36a40e3f68fd29bf5) Fix compilation ### 📊 Changes **7 files changed** (+55 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+17 -20) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+9 -9) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+6 -6) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+15 -15) 📝 `src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp` (+3 -2) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+4 -6) 📝 `src/inc/til/math.h` (+1 -1) </details> ### 📄 Description I noticed this bug while resizing my window on my 150% scale display. Every 3 "snaps" of the window size, it would fail to resize the text buffer. I found that this occurs, because we convert the swap chain size from a float into a double, which converts my 597.333313 height into 597.33331298828125, which then multiplied by 1.5 results in 895.999969482421875. If you just cast this to an integer, it'll result in a height of 895px instead of the expected 896px. This PR addresses the issue in two ways: * Replace casts to integers with `lrint` or `floor`, etc. * Remove many of the redundant double <> float conversions. ## PR Checklist * Resizing my window always resizes the text buffer ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?