starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15110] [MERGED] Upgrade clang-format to 15.0.7 #30429

New Issue
Open
opened 2026-01-31 09:40:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:40:47 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15110
Author: @lhecker
Created: 4/4/2023
Status: ✅ Merged
Merged: 4/5/2023
Merged by: @zadjii-msft

Base: main ← Head: dev/lhecker/clang-format-15

📝 Commits (2)

  • 9fc3580 Upgrade clang-format to 15.0.7
  • 2348e8d Add options back that are still relevant

📊 Changes

13 files changed (+188 additions, -138 deletions)

View changed files

📝 .clang-format (+3 -57)
📝 .github/actions/spelling/expect/expect.txt (+1 -2)
📝 src/cascadia/TerminalControl/ControlCore.h (+13 -7)
📝 src/cascadia/TerminalControl/ControlSettings.h (+9 -3)
📝 src/cascadia/TerminalSettingsEditor/ViewModelHelpers.h (+27 -15)
📝 src/cascadia/TerminalSettingsEditor/ViewModelHelpers.idl.h (+4 -1)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.h (+12 -6)
📝 src/cascadia/TerminalSettingsModel/IInheritable.idl.h (+4 -1)
📝 src/cascadia/inc/cppwinrt_utils.h (+82 -34)
📝 src/inc/til/bytes.h (+1 -1)
📝 src/inc/til/pmr.h (+2 -2)
📝 src/renderer/atlas/AtlasEngine.h (+29 -8)
📝 tools/packages.config (+1 -1)

📄 Description

Upgrading clang-format lead to a few changes in the formatting
of code inside macros. Apart from the upgrade, I've also spent
some time removing all options from .clang-format that are
redundant with BasedOnStyle: Microsoft.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15110 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 4/4/2023 **Status:** ✅ Merged **Merged:** 4/5/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/lhecker/clang-format-15` --- ### 📝 Commits (2) - [`9fc3580`](https://github.com/microsoft/terminal/commit/9fc3580eca7b3088cb589dd1db2476d7a7b959fd) Upgrade clang-format to 15.0.7 - [`2348e8d`](https://github.com/microsoft/terminal/commit/2348e8d7331d41411e75aac09c1f326e04fbcd26) Add options back that are still relevant ### 📊 Changes **13 files changed** (+188 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `.clang-format` (+3 -57) 📝 `.github/actions/spelling/expect/expect.txt` (+1 -2) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+13 -7) 📝 `src/cascadia/TerminalControl/ControlSettings.h` (+9 -3) 📝 `src/cascadia/TerminalSettingsEditor/ViewModelHelpers.h` (+27 -15) 📝 `src/cascadia/TerminalSettingsEditor/ViewModelHelpers.idl.h` (+4 -1) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.h` (+12 -6) 📝 `src/cascadia/TerminalSettingsModel/IInheritable.idl.h` (+4 -1) 📝 `src/cascadia/inc/cppwinrt_utils.h` (+82 -34) 📝 `src/inc/til/bytes.h` (+1 -1) 📝 `src/inc/til/pmr.h` (+2 -2) 📝 `src/renderer/atlas/AtlasEngine.h` (+29 -8) 📝 `tools/packages.config` (+1 -1) </details> ### 📄 Description Upgrading clang-format lead to a few changes in the formatting of code inside macros. Apart from the upgrade, I've also spent some time removing all options from .clang-format that are redundant with `BasedOnStyle: Microsoft`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30429
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?